New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beth's code review #4

Open

eliazzo opened this issue Oct 18, 2023 · 0 comments

eliazzo commented Oct 18, 2023

UX - looks great! Really intuitive 💣
QA - Functions are well-named 👏

Make sure you're removing unused code: eg in src/components/Modal.jsx there's an entire function commented out

Also, unused imports eg useEffect and createBoard in src/components/Modal.jsx

Error handling - there's no error handling for cases where the number of mines exceeds the number of cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment