Skip to content

buck starlark lint: show the warning name or suppression instructions #1086

@lf-

Description

@lf-

Currently the warning names and suppression comment are undocumented. The output should mention how to suppress a warning as well as what the actual warning code is, IMO, which it does not do at the moment.

ERRO formatter | buck-starlark-lint: failed to apply with options '[starlark lint]': exit status 3

[2025-08-25T16:28:05.704-07:00] RE Session: GRPC-SESSION-ID
[2025-08-25T16:28:05.704-07:00] Build ID: aaaaaa-aa-aa-aaa-aaaaaa
toolchains/nix.bzl:86:33-40: Unused argument `actions`
[2025-08-25T16:28:05.710-07:00] Network: Up: 0B  Down: 0B  (GRPC-SESSION-ID)
Command failed: 
Found 1 lints

I don't know what's up with that log output but I am probably invoking it wrong.

Code:

fn short_name(&self) -> &'static str {
match self {
Self::UnusedLoad(..) => "unused-load",
Self::UnusedAssign(..) => "unused-assign",
Self::UnusedArgument(..) => "unused-argument",
Self::UsingUnassigned(..) => "using-unassigned",
Self::UsingUndefined(..) => "using-undefined",
Self::UsingMaybeUndefined(..) => "using-maybe-undefined",
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions