fix(theme): Fix footnote ref scrolling behind the navbar when footnote back reference clicked #11289
+65
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +315 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +305 B (0%) Total Size: 11.9 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When clicking a footnote at the bottom of a MDX page, we navigate to the footnote reference within that MDX doc. Unfortunately, the navbar can cover that reference, making it unclear we navigated to it.
Similar to anchors/headings, let's apply a CSS
scroll-margin-top: calc(var(--ifm-navbar-height) + 0.5rem);for footnote references to ensure that are not covered by the navbar.Fix #11232
Test Plan
Local test only 😅
Our website doesn't use a sticky navbar, so the problem is not really visible here since it hides whenever we click a footnote back reference. But the preview can still show the little effect of
scroll-margin-top: 0.5rem;in that case, and there's more margin when clicking than in prod.Test links
https://deploy-preview-11289--docusaurus-2.netlify.app/