-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
fix(translations): Add missing Ukrainian translations #11305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @maluke! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There still are a few untranslated labels, can you help translate them please?
Otherwise we can merge as is, still an improvement
"theme.docs.sidebar.collapseButtonAriaLabel": "Згорнути сайдбар", | ||
"theme.docs.sidebar.collapseButtonTitle": "Згорнути сайдбар", | ||
"theme.docs.sidebar.expandButtonAriaLabel": "Розгорнути сайдбар", | ||
"theme.docs.sidebar.expandButtonTitle": "Розгорнути сайдбар", | ||
"theme.docs.sidebar.navAriaLabel": "Docs sidebar", | ||
"theme.docs.sidebar.navAriaLabel": "Сайдбар документації", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next label is also untranslated, can you translate it too?
Sure thing. I think I got them all this time. |
Thanks If you are using the UI, instead of creating a 2nd patch branch (and opening a new PR?), you can also edit the files on your existing patch-1 branch. Let me know if you need help |
Yeah, I mistyped "ukrainian" in the original commit message, so I thought I'll fix that as well and I couldn't force-push to the old branch from the UI. Hopefully this isn't too inconvenient. If you really need me to put the fix on that branch, let me know. Thank you for the work you do on Docusaurus. I wasted days trying to get a number of other static site generators to do something resembling what I wanted, and only after discovering it I got something I'm happy with. In half a day too. So thanks, and it really deserves to be better known. |
Got a little messy for a second, but I force pushed the updated commit to the PR branch. |
LGTM thanks 👍 |
Motivation
This adds a few missing translation strings in Ukrainian translation.