Skip to content

fix(translations): Add missing Ukrainian translations #11305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

maluke
Copy link
Contributor

@maluke maluke commented Jul 3, 2025

Motivation

This adds a few missing translation strings in Ukrainian translation.

@maluke maluke requested review from slorber and Josh-Cena as code owners July 3, 2025 17:57
@facebook-github-bot
Copy link
Contributor

Hi @maluke!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jul 3, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e480b59
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6867cb405b6dd80008d993cd
😎 Deploy Preview https://deploy-preview-11305--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@maluke maluke changed the title Add missing ukrainian translations Add missing Ukrainian translations Jul 3, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 3, 2025
Copy link

github-actions bot commented Jul 3, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 35 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 60 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 66 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 55 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 59 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 69 🟢 100 🟢 100 🟠 86 Report

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

There still are a few untranslated labels, can you help translate them please?

Otherwise we can merge as is, still an improvement

"theme.docs.sidebar.collapseButtonAriaLabel": "Згорнути сайдбар",
"theme.docs.sidebar.collapseButtonTitle": "Згорнути сайдбар",
"theme.docs.sidebar.expandButtonAriaLabel": "Розгорнути сайдбар",
"theme.docs.sidebar.expandButtonTitle": "Розгорнути сайдбар",
"theme.docs.sidebar.navAriaLabel": "Docs sidebar",
"theme.docs.sidebar.navAriaLabel": "Сайдбар документації",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next label is also untranslated, can you translate it too?

@slorber slorber changed the title Add missing Ukrainian translations fix(translations): Add missing Ukrainian translations Jul 4, 2025
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 4, 2025
@maluke
Copy link
Contributor Author

maluke commented Jul 4, 2025

Sure thing. I think I got them all this time.

maluke@e480b59

@slorber
Copy link
Collaborator

slorber commented Jul 4, 2025

Thanks

If you are using the UI, instead of creating a 2nd patch branch (and opening a new PR?), you can also edit the files on your existing patch-1 branch.

Let me know if you need help

@maluke
Copy link
Contributor Author

maluke commented Jul 4, 2025

Yeah, I mistyped "ukrainian" in the original commit message, so I thought I'll fix that as well and I couldn't force-push to the old branch from the UI. Hopefully this isn't too inconvenient. If you really need me to put the fix on that branch, let me know.

Thank you for the work you do on Docusaurus. I wasted days trying to get a number of other static site generators to do something resembling what I wanted, and only after discovering it I got something I'm happy with. In half a day too. So thanks, and it really deserves to be better known.

@maluke
Copy link
Contributor Author

maluke commented Jul 4, 2025

Got a little messy for a second, but I force pushed the updated commit to the PR branch.

@maluke maluke reopened this Jul 4, 2025
@slorber slorber added pr: translations This PR is related to Docusaurs core, theme or website translations and removed pr: bug fix This PR fixes a bug in a past release. labels Jul 4, 2025
@slorber
Copy link
Collaborator

slorber commented Jul 4, 2025

LGTM thanks 👍

@slorber slorber merged commit 4c3daab into facebook:main Jul 4, 2025
42 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: translations This PR is related to Docusaurs core, theme or website translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants