Add new getPortStates Thrift API for Port Manager Mode (portNames->portStates)

Summary: as titled, makes it easier to implement D90685862.

Reviewed By: birdsoup

Differential Revision: D90710424

fbshipit-source-id: 0095caa1cd3e9528181aa2a457f576e9aeb2bdae

Author: shiva-menta

fboss/qsfp_service/PortManager.cpp

@@ -2199,12 +2199,37 @@ phy::PortPrbsState PortManager::getXphyPortPrbs(
 void PortManager::getPortStates(
     std::map<int32_t, PortStateMachineState>& states,
     std::unique_ptr<std::vector<int32_t>> ids) {
+  if (ids->empty()) {
+    for (const auto& [_, portId] : portNameToPortID_) {
+      ids->push_back(portId);
+    }
+  }
+
   for (const auto& id : *ids) {
     auto portId = PortID(id);
     try {
       states.emplace(id, getPortState(portId));
     } catch (const FbossError& /* e */) {
-      XLOG(WARN) << "Unrecognized Port:" << portId;
+      XLOG(WARN) << "Unrecognized Port: " << portId;
+    }
+  }
+}
+
+void PortManager::getPortStates(
+    std::map<std::string, PortStateMachineState>& states,
+    std::unique_ptr<std::vector<std::string>> portNames) {
+  if (portNames->empty()) {
+    for (const auto& [portNameStr, _] : portNameToPortID_) {
+      portNames->push_back(portNameStr);
+    }
+  }
+
+  for (const auto& portNameStr : *portNames) {
+    try {
+      auto portId = getPortIDByPortNameOrThrow(portNameStr);
+      states.emplace(portNameStr, getPortState(portId));
+    } catch (const FbossError& /* e */) {
+      XLOG(WARN) << "Unrecognized Port:" << portNameStr;
     }
   }
 }

fboss/qsfp_service/PortManager.h

@@ -393,6 +393,10 @@ class PortManager {
       std::map<int32_t, PortStateMachineState>& states,
       std::unique_ptr<std::vector<int32_t>> ids);
 
+  void getPortStates(
+      std::map<std::string, PortStateMachineState>& states,
+      std::unique_ptr<std::vector<std::string>> portNames);
+
   virtual void initExternalPhyMap(bool forceWarmboot = false);
 
  protected:

fboss/qsfp_service/QsfpServiceHandler.cpp

@@ -107,6 +107,16 @@ void QsfpServiceHandler::getPortStateMachineState(
   }
 }
 
+void QsfpServiceHandler::getPortStateMachineStateFromPortNames(
+    std::map<std::string, PortStateMachineState>& info,
+    std::unique_ptr<std::vector<std::string>> portNames) {
+  auto log = LOG_THRIFT_CALL(INFO);
+  if (FLAGS_port_manager_mode) {
+    // Only populate if port manager mode is enabled.
+    portManager_->getPortStates(info, std::move(portNames));
+  }
+}
+
 void QsfpServiceHandler::getPortMediaInterface(
     std::map<std::string, MediaInterfaceCode>& portMediaInterface) {
   auto log = LOG_THRIFT_CALL(INFO);

fboss/qsfp_service/QsfpServiceHandler.h

@@ -49,6 +49,13 @@ class QsfpServiceHandler
       std::map<int32_t, PortStateMachineState>& info,
       std::unique_ptr<std::vector<int32_t>> ids) override;
 
+  /*
+   * Returns all qsfp information for the transceiver
+   */
+  void getPortStateMachineStateFromPortNames(
+      std::map<std::string, PortStateMachineState>& info,
+      std::unique_ptr<std::vector<std::string>> portNames) override;
+
   /*
    * Returns portName to configured media interface
    */

fboss/qsfp_service/if/BUCK

@@ -103,6 +103,7 @@ thrift_library(
         ":transceiver",
         ":transceiver_validation",
         "//fboss/agent:switch_config",
+        "//thrift/annotation:thrift",
     ],
 )
 
@@ -133,6 +134,7 @@ thrift_library(
         ":transceiver",
         "//fboss/lib/if:pim_state",
         "//fboss/lib/phy:phy",
+        "//thrift/annotation:thrift",
     ],
 )
 
@@ -161,6 +163,7 @@ thrift_library(
         ":transceiver",
         "//fboss/agent/hw:hardware_stats",
         "//fboss/lib/phy:phy",
+        "//thrift/annotation:thrift",
     ],
 )
 
@@ -185,6 +188,9 @@ thrift_library(
     thrift_py_options = "json,sort_keys",
     thrift_rust_options = "serde",
     thrift_srcs = {"port_state.thrift": []},
+    deps = [
+        "//thrift/annotation:thrift",
+    ],
 )
 
 thrift_library(
@@ -213,5 +219,6 @@ thrift_library(
         "//fboss/agent:switch_config",
         "//fboss/lib/if:fboss_common",
         "//thrift/annotation:cpp",
+        "//thrift/annotation:thrift",
     ],
 )

fboss/qsfp_service/if/qsfp.thrift

@@ -32,6 +32,16 @@ service QsfpService extends phy.FbossCommonPhyCtrl {
     1: list<i32> idx,
   ) throws (1: fboss.FbossBaseError error);
 
+  /*
+   * Get state information about a port
+   */
+  map<
+    string,
+    transceiver.PortStateMachineState
+  > getPortStateMachineStateFromPortNames(1: list<string> portNames) throws (
+    1: fboss.FbossBaseError error,
+  );
+
   /*
    * Get config validation status of a transceiver
    */