Remove unused private from fboss/agent/InterfaceStats.cpp +25

Summary:
`-Wunused-private-field` has identified an unused private field such fields consume unnecessary memory and create readability issues. This diff removes one or more such fields and their associated initialization code.

This diff was generated by Claude using fbcode/scripts/rbarnes/work-plans/unused_field_fixes_plan.md and manually reviewed by r-barnes. I consider it low risk because the compiler has identified the underlying issue and the fix itself is hard to get wrong in a way that doesn't break compilation: eliminating an unused field would cause a compiler error, forgetting to remove constructor code would cause a compiler error, mauling the remaining constructors in any obvious way would be a compiler error, commenting out or forgetting to comment out constructor arguments would be a compiler error.

Differential Revision: D90823526

fbshipit-source-id: 93ac90720efe66723f64101c63cf91c53aa1cec8

Author: r-barnes

fboss/agent/InterfaceStats.cpp

@@ -17,8 +17,8 @@ namespace facebook::fboss {
 InterfaceStats::InterfaceStats(
     InterfaceID intfID,
     std::string intfName,
-    SwitchStats* switchStats)
-    : intfID_(intfID), intfName_(intfName), switchStats_(switchStats) {
+    SwitchStats* /*switchStats*/)
+    : intfID_(intfID), intfName_(intfName) {
   if (!intfName_.empty()) {
     tcData().addStatValue(getCounterKey(kRouterAdvertisement), 0, SUM);
   }

fboss/agent/InterfaceStats.h

@@ -27,7 +27,6 @@ class InterfaceStats {
 
   InterfaceID intfID_;
   std::string intfName_;
-  SwitchStats* switchStats_;
 };
 
 } // namespace facebook::fboss

fboss/agent/SwAgentInitializer.h

@@ -56,14 +56,11 @@ class SwAgentSignalHandler : public SignalHandler {
  public:
   SwAgentSignalHandler(
       folly::EventBase* eventBase,
-      SwSwitch* sw,
+      SwSwitch* /*sw*/,
       SignalHandler::StopServices stopServices)
-      : SignalHandler(eventBase, std::move(stopServices)), sw_(sw) {}
+      : SignalHandler(eventBase, std::move(stopServices)) {}
 
   void signalReceived(int /*signum*/) noexcept override;
-
- private:
-  SwSwitch* sw_;
 };
 
 class SwAgentInitializer : public AgentInitializer {

fboss/agent/hw/sai/switch/SaiUdfManager.h

@@ -54,9 +54,9 @@ class SaiUdfManager {
 
   SaiUdfManager(
       SaiStore* saiStore,
-      SaiManagerTable* managerTable,
-      const SaiPlatform* platform)
-      : saiStore_(saiStore), managerTable_(managerTable), platform_(platform) {}
+      SaiManagerTable* /*managerTable*/,
+      const SaiPlatform* /*platform*/)
+      : saiStore_(saiStore) {}
 
   static auto constexpr kMaskDontCare = 0;
   static auto constexpr kMaskAny = 0xFFFF;
@@ -103,8 +103,6 @@ class SaiUdfManager {
   UdfMatchHandles udfMatchHandles_;
   UdfGroupHandles udfGroupHandles_;
   SaiStore* saiStore_;
-  SaiManagerTable* managerTable_;
-  const SaiPlatform* platform_;
 };
 
 } // namespace facebook::fboss

fboss/agent/hw/sai/switch/SaiWredManager.h

@@ -28,9 +28,9 @@ class SaiWredManager {
  public:
   SaiWredManager(
       SaiStore* saiStore,
-      SaiManagerTable* managerTable,
-      const SaiPlatform* platform)
-      : saiStore_(saiStore), managerTable_(managerTable), platform_(platform) {}
+      SaiManagerTable* /*managerTable*/,
+      const SaiPlatform* /*platform*/)
+      : saiStore_(saiStore) {}
 
   std::shared_ptr<SaiWred> getOrCreateProfile(const PortQueue& queue);
 
@@ -41,8 +41,6 @@ class SaiWredManager {
       const PortQueue& queue) const;
 
   SaiStore* saiStore_;
-  SaiManagerTable* managerTable_;
-  const SaiPlatform* platform_;
 };
 
 } // namespace facebook::fboss

fboss/agent/hw/sai/switch/npu/bcm/SaiTamManager.cpp

@@ -207,9 +207,9 @@ void unbindTamObjectFromSwitchAndPort(
 
 SaiTamManager::SaiTamManager(
     SaiStore* saiStore,
-    SaiManagerTable* managerTable,
-    SaiPlatform* platform)
-    : saiStore_(saiStore), managerTable_(managerTable), platform_(platform) {}
+    SaiManagerTable* /*managerTable*/,
+    SaiPlatform* /*platform*/)
+    : saiStore_(saiStore) {}
 
 #if defined(BRCM_SAI_SDK_DNX_GTE_11_0)
 void SaiTamManager::addDnxMirrorOnDropReport(

fboss/agent/test/AgentEnsembleIntegrationTestBase.h

@@ -18,8 +18,5 @@ class AgentEnsembleIntegrationTestBase : public AgentEnsembleTest {
  public:
   void SetUp() override;
   void TearDown() override;
-
- private:
-  const AgentEnsemble* ensemble_;
 };
 } // namespace facebook::fboss

fboss/fsdb/oper/CowDeletePathTraverseHelper.h

@@ -23,7 +23,7 @@ struct CowDeletePathTraverseHelper
   using Base::path;
   using Base::shouldShortCircuit;
 
-  CowDeletePathTraverseHelper(SubscriptionPathStore* root) : root_(root) {
+  CowDeletePathTraverseHelper(SubscriptionPathStore* root) {
     pathStores_.emplace_back(root);
   }
 
@@ -68,7 +68,6 @@ struct CowDeletePathTraverseHelper
 
  private:
   std::vector<SubscriptionPathStore*> pathStores_;
-  SubscriptionPathStore* root_{nullptr};
 };
 
 } // namespace facebook::fboss::fsdb

fboss/fsdb/tests/utils/FsdbTestServer.h

@@ -76,7 +76,6 @@ class FsdbTestServer {
   void startTestServer(uint16_t port);
   void stopTestServer();
   std::string getPublisherId(int publisherIdx) const;
-  const int kMaxPublishers_{3};
   std::shared_ptr<FsdbConfig> config_;
   std::shared_ptr<ServiceHandler> handler_;
   uint16_t fsdbPort_{};

fboss/lib/bsp/BspPhyIO.cpp

@@ -12,8 +12,7 @@
 
 namespace facebook::fboss {
 
-BspPhyIO::BspPhyIO(int pimID, BspPhyIOControllerInfo& controllerInfo)
-    : pimID_(pimID) {
+BspPhyIO::BspPhyIO(int pimID, BspPhyIOControllerInfo& controllerInfo) {
   auto mdioDevName = *controllerInfo.devicePath();
   auto controllerId = *controllerInfo.controllerId();
   XLOG(DBG5) << __func__ << ": mdioDevName=" << mdioDevName