Fix CQS signal clang-diagnostic-shadow in fbcode/fboss/qsfp_service

Reviewed By: shiva-menta

Differential Revision: D91210923

fbshipit-source-id: 3e641855f2e434365e1cd4930409549048e92070

Author: generatedunixname537391475639613

fboss/qsfp_service/PortManager.cpp

@@ -905,11 +905,11 @@ void PortManager::setOverrideXphyNoTcvrPortToProfileForTesting(
       auto zPortID = getPortIDByPortName(*portPairs.zPortName());
       // If the SW port does NOT have a transceiver but HAS XPHY, add it to
       // overrideXphyNoTcvrPortToProfileForTest_ (XPHY backplane port)
-      for (const auto& portID : {aPortID, zPortID}) {
-        if (portID.has_value() && !portHasTransceiver(*portID) &&
-            cachedXphyPorts_.find(*portID) != cachedXphyPorts_.end()) {
+      for (const auto& pID : {aPortID, zPortID}) {
+        if (pID.has_value() && !portHasTransceiver(*pID) &&
+            cachedXphyPorts_.find(*pID) != cachedXphyPorts_.end()) {
           overrideXphyNoTcvrPortToProfileForTest_.emplace(
-              *portID, *portPairs.profileID());
+              *pID, *portPairs.profileID());
         }
       }
     }