Skip to content

Commit 31c956b

Browse files
Temporary put IDPROM_READ into expected errors
Summary: Temporary put IDPROM_READ failure for 1-0053 into expected errors. It is going to be removed once it's fixed. As per scuba data this issue only occurs for montblanc, janga800bic and tahan800bc: https://fburl.com/scuba/fboss_platform_manager/kqxyx8il Reviewed By: somasun Differential Revision: D89675695 fbshipit-source-id: 406c5ddcb437f8676b9456457eee352ff5f452ad
1 parent cd94b36 commit 31c956b

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

fboss/platform/platform_manager/ExplorationSummary.cpp

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,33 @@ void ExplorationSummary::addError(
2626
ExplorationError newError;
2727
newError.errorType() = toExplorationErrorTypeStr(errorType);
2828
newError.message() = message;
29+
30+
auto addExpectedError =
31+
[this](const std::string& devicePath, ExplorationError& newError) {
32+
devicePathToExpectedErrors_[devicePath].push_back(newError);
33+
nExpectedErrs_++;
34+
};
35+
36+
// https://fb.workplace.com/groups/1419427118405392/permalink/2752297575118333
37+
// https://fb.workplace.com/groups/264616536023347/permalink/907140855104242/
38+
// for details. To be removed once the issue is fixed.
39+
if ((*platformConfig_.platformName() == "MONTBLANC" ||
40+
*platformConfig_.platformName() == "JANGA800BIC" ||
41+
*platformConfig_.platformName() == "TAHAN800BC") &&
42+
errorType == ExplorationErrorType::IDPROM_READ &&
43+
devicePath == "/[IDPROM]") {
44+
addExpectedError(devicePath, newError);
45+
return;
46+
}
47+
2948
if ((errorType == ExplorationErrorType::SLOT_PM_UNIT_ABSENCE ||
3049
errorType == ExplorationErrorType::RUN_DEVMAP_SYMLINK) &&
3150
isSlotExpectedToBeEmpty(devicePath)) {
32-
devicePathToExpectedErrors_[devicePath].push_back(newError);
33-
nExpectedErrs_++;
34-
} else {
35-
devicePathToErrors_[devicePath].push_back(newError);
36-
nErrs_++;
51+
addExpectedError(devicePath, newError);
52+
return;
3753
}
54+
devicePathToErrors_[devicePath].push_back(newError);
55+
nErrs_++;
3856
}
3957

4058
void ExplorationSummary::addError(

0 commit comments

Comments
 (0)