Skip to content

Commit 6d1cdea

Browse files
Harshit Gulatimeta-codesync[bot]
authored andcommitted
Enable FEC stats on mgmt port on TH5/TH6
Summary: Latest 14.X SDK has fixed the previous issue Reviewed By: daiwei1983 Differential Revision: D91005103 fbshipit-source-id: 5a7661227ab4e8a4da66dc1005a01e2432ab0497
1 parent 7a930a5 commit 6d1cdea

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

fboss/agent/hw/sai/switch/SaiPortManager.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1965,10 +1965,10 @@ bool SaiPortManager::fecStatsSupported(PortID portId) const {
19651965
platform_->getAsic()->getAsicType() ==
19661966
cfg::AsicType::ASIC_TYPE_TOMAHAWK6) &&
19671967
getPortType(portId) == cfg::PortType::MANAGEMENT_PORT) {
1968-
// TODO(daiweix): follow up why not supported on TH5 mgmt port, e.g.
1969-
// SAI_PORT_STAT_IF_IN_FEC_CORRECTABLE_FRAMES
1968+
#if !defined(BRCM_SAI_SDK_GTE_14_0)
19701969
// CS00012443185
19711970
return false;
1971+
#endif
19721972
}
19731973
return platform_->getAsic()->isSupported(HwAsic::Feature::SAI_FEC_COUNTERS) &&
19741974
utility::isReedSolomonFec(getFECMode(portId));
@@ -1980,10 +1980,10 @@ bool SaiPortManager::fecCorrectedBitsSupported(PortID portId) const {
19801980
platform_->getAsic()->getAsicType() ==
19811981
cfg::AsicType::ASIC_TYPE_TOMAHAWK6) &&
19821982
getPortType(portId) == cfg::PortType::MANAGEMENT_PORT) {
1983-
// TODO(daiweix): follow up why not supported on TH5 mgmt port, e.g.
1984-
// SAI_PORT_STAT_IF_IN_FEC_CORRECTED_BITS
1983+
#if !defined(BRCM_SAI_SDK_GTE_14_0)
19851984
// CS00012443185
19861985
return false;
1986+
#endif
19871987
}
19881988
if (platform_->getAsic()->isSupported(
19891989
HwAsic::Feature::SAI_FEC_CORRECTED_BITS) &&

0 commit comments

Comments
 (0)