Skip to content

Commit 7468cad

Browse files
Khiruthigai (Kitty) Balasubramanianmeta-codesync[bot]
authored andcommitted
Fix AgentQueuePerHostTests (#785)
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` clang-format.............................................................Passed black................................................(no files to check)Skipped shellcheck...........................................(no files to check)Skipped shfmt................................................(no files to check)Skipped trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check json...........................................(no files to check)Skipped check for merge conflicts................................................Passed Pull Request resolved: #785 Test Plan: Verify the test run manually. Reviewed By: vasantspatil Differential Revision: D90421655 Pulled By: Tianyu-Meta fbshipit-source-id: af6ad50eb04987cb93d602159b2b2abb9b3fda89
1 parent 33c440e commit 7468cad

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

fboss/agent/test/agent_hw_tests/AgentQueuePerHostTests.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,13 @@ class AgentQueuePerHostTest : public AgentHwTest {
452452

453453
// counts ttl >= 128 packet only
454454
EXPECT_EVENTUALLY_EQ(packetsAfter - packetsBefore, 1);
455-
if (frontPanel) {
456-
EXPECT_EVENTUALLY_EQ(bytesAfter - bytesBefore, packetSize);
455+
if (isSupportedOnAllAsics(HwAsic::Feature::ACL_BYTE_COUNTER)) {
456+
if (frontPanel) {
457+
EXPECT_EVENTUALLY_EQ(bytesAfter - bytesBefore, packetSize);
458+
}
459+
// TODO: Still need to debug why we get extra 4 bytes for CPU port
460+
EXPECT_EVENTUALLY_TRUE(bytesAfter - bytesBefore >= packetSize);
457461
}
458-
// TODO: Still need to debug why we get extra 4 bytes for CPU port
459-
EXPECT_EVENTUALLY_TRUE(bytesAfter - bytesBefore >= packetSize);
460462
});
461463
}
462464
};

0 commit comments

Comments
 (0)