Add missing cmake dependencies to match BUCK build configuration

This commit adds missing dependencies to cmake targets that were present
in the corresponding BUCK targets but missing in cmake. These dependencies
were detected using the new `buck_cmake_dep_checker.py` tool.

This commit fixes all but 11 of the dependencies problems found by the
tool. The remaining 11 will be fixed in a subsequent change where a bit
of restructuring is needed in the cmake files to match the BUCK files
more closely.

## Fixes in cmake/Agent.cmake:

1. setup_thrift: Added thrift_method_rate_limit
   fboss/agent/BUCK has `//fboss/lib:thrift_method_rate_limit` in exported_deps for setup_thrift

2. utils: Added hw_switch_fb303_stats
   fboss/agent/BUCK has `//fboss/agent/hw:hw_switch_fb303_stats` in exported_deps for utils

3. stats: Added common_utils
   fboss/agent/BUCK has `//fboss/lib:common_utils` in exported_deps for stats

4. ecmp_resource_manager: Added ref_map, stats, and utils
   fboss/agent/BUCK has `//fboss/lib:ref_map`, `:stats`, and `:utils` in exported_deps
   for ecmp_resource_manager

5. platform_base: Added utils, product_info, and fboss_event_base
   fboss/agent/BUCK has `:utils`, `//fboss/lib/platforms:product-info`, and `:fboss_event_base`
   in exported_deps for platform_base

6. hw_switch_handler: Added fboss_event_base
   fboss/agent/BUCK has `:fboss_event_base` in exported_deps for hw_switch_handler

7. switchinfo_utils: Added fboss_error and load_agent_config
   fboss/agent/BUCK has `:fboss-error` and `:load_agent_config` in exported_deps for switchinfo_utils

8. core: Added packet_factory to core_libs variable
   fboss/agent/BUCK has `//fboss/agent/packet:packet_factory` in deps for core

9. fboss_event_base: Added agent_features
   fboss/agent/BUCK has `:agent_features` in exported_deps for fboss_event_base

10. agent_netwhoami: Added common_file_utils
    fboss/agent/BUCK has `//fboss/lib:common_file_utils` in exported_deps for agent_netwhoami

## Fixes in cmake/AgentHw.cmake:

11. hw_fb303_stats: Added error
    fboss/agent/hw/BUCK has `//fboss/agent:fboss-error` in exported_deps for hw_fb303_stats

12. hw_port_fb303_stats: Added hw_fb303_stats and fboss_types
    fboss/agent/hw/BUCK has `:hw_fb303_stats` and `//fboss/agent:fboss-types`
    in exported_deps for hw_port_fb303_stats

## Fixes in cmake/AgentHwMock.cmake:

13. hw_mock: Added handler
    fboss/agent/hw/mock/BUCK has `//fboss/agent:handler` in exported_deps for mock

## Fixes in cmake/AgentHwSaiHwTest.cmake:

14. agent_hw_test_thrift_handler: Added hw_switch
    fboss/agent/hw/bcm/tests/BUCK has `//fboss/agent:hw_switch` in exported_deps
    for agent_hw_test_thrift_handler

## Fixes in cmake/AgentHwSwitchAsics.cmake:

15. switch_asics: Added agent_features, error, and fboss_types
    fboss/agent/hw/switch_asics/BUCK has `//fboss/agent:agent_features`,
    `//fboss/agent:fboss-error`, and `//fboss/agent:fboss-types` in exported_deps for switch_asics

## Fixes in cmake/AgentHwTest.cmake:

16. config_factory: Added acl_test_utils, split_agent_thrift_syncer, multiswitch_test_server
    fboss/agent/hw/test/BUCK has `//fboss/agent/test/utils:acl_test_utils`,
    `//fboss/agent:split_agent_thrift_syncer`, and `//fboss/agent/test:multiswitch_test_server`
    in exported_deps for config_factory

17. hw_packet_utils: Added agent_test_utils
    fboss/agent/hw/test/BUCK has `//fboss/agent/test:utils` in exported_deps for hw_packet_utils

18. hw_copp_utils: Added copp_test_utils and hw_packet_utils
    fboss/agent/hw/test/BUCK has `//fboss/agent/test/utils:copp_test_utils` and
    `:hw_packet_utils` in exported_deps for hw_copp_utils

19. hw_link_state_toggler: Added test_ensemble_if
    fboss/agent/test/BUCK has `:test_ensemble_if` in exported_deps for linkstate_toggler

20. load_balancer_utils: Added load_balancer_test_utils
    fboss/agent/hw/test/BUCK has `//fboss/agent/test/utils:load_balancer_test_utils`
    in exported_deps for load_balancer_utils

## Fixes in cmake/AgentLldp.cmake:

21. lldp: Added agent_features and cow_storage
    fboss/agent/lldp/BUCK has `//fboss/agent:agent_features` and
    `//fboss/thrift_cow/storage:cow_storage` in exported_deps for lldp

## Fixes in cmake/AgentPacket.cmake:

22. packet_factory: Added hw_switch
    fboss/agent/packet/BUCK has `//fboss/agent:hw_switch` in deps for packet_factory

## Fixes in cmake/AgentPlatformsCommon.cmake:

23. platform_mapping_utils: Added platform_mode
    fboss/agent/platforms/common/BUCK has `//fboss/lib/platforms:platform_mode`
    in exported_deps for platform_mapping_utils

## Fixes in cmake/AgentPlatformsCommonGalaxy.cmake:

24. galaxy_platform_mapping: Added utils
    fboss/agent/platforms/common/galaxy/BUCK has `//fboss/agent:utils`
    in exported_deps for galaxy_platform_mapping

## Fixes in cmake/AgentPlatformsCommonMinipack.cmake:

25. minipack_platform_mapping: Added platform_mode
    fboss/agent/platforms/common/minipack/BUCK has `//fboss/lib/platforms:platform_mode`
    in exported_deps for minipack_platform_mapping

## Fixes in cmake/AgentPlatformsCommonUtils.cmake:

26. wedge_led_utils: Added wedge_transceiver
    fboss/agent/platforms/common/utils/BUCK has `//fboss/qsfp_service/platforms/wedge:wedge-transceiver`
    in exported_deps for wedge-led-utils

## Fixes in cmake/AgentRib.cmake:

27. standalone_rib: Added fboss_event_base and utils
    fboss/agent/rib/BUCK has `//fboss/agent:fboss_event_base` and `//fboss/agent:utils`
    in exported_deps for standalone_rib

28. network_to_route_map: Added state
    fboss/agent/rib/BUCK has `//fboss/agent/state:state` in exported_deps
    for network_to_route_map

## Fixes in cmake/AgentState.cmake:

29. state: Added address_utils
    fboss/agent/state/BUCK has `//fboss/agent:address_utils` in exported_deps for state

30. state_utils: Added hwswitch_matcher and state
    fboss/agent/state/BUCK has `:state` and `//fboss/agent:hwswitch_matcher`
    in exported_deps for state_utils

## Fixes in cmake/AgentTest.cmake:

31. agent_test_utils: Added route_distribution_gen
    fboss/agent/test/BUCK has `:route_distribution_gen` in exported_deps for utils

32. multinode_tests: Added agent_test_utils, hw_copp_utils, hw_packet_utils, load_balancer_utils
    fboss/agent/test/BUCK has `:utils`, `//fboss/agent/hw/test:hw_copp_utils`,
    `//fboss/agent/hw/test:hw_packet_utils`, and `//fboss/agent/hw/test:load_balancer_utils`
    in exported_deps for multinode_tests

33. agent_ensemble: Added sw_agent_initializer
    fboss/agent/test/BUCK has `//fboss/agent:sw_agent_initializer` in exported_deps
    for agent_ensemble

34. linkstate_toggler: Added test_ensemble_if
    fboss/agent/test/BUCK has `:test_ensemble_if` in exported_deps for linkstate_toggler

35. system_scale_test_utils: Added trap_packet_utils
    fboss/agent/test/utils/BUCK has `:trap_packet_utils` in exported_deps
    for system_scale_test_utils

## Fixes in cmake/AgentTestAgentHwTests.cmake:

36. agent_hw_test_src: Added load_balancer_test_runner_h
    fboss/agent/test/agent_hw_tests/BUCK has `//fboss/agent/test/utils:load_balancer_test_runner_h`
    in exported_deps for agent_hw_test_src

## Fixes in cmake/AgentTestLinkTests.cmake:

37. link_tests: Added trap_packet_utils, hw_qos_utils, hw_test_fabric_utils
    fboss/agent/test/link_tests/BUCK has `//fboss/agent/test/utils:trap_packet_utils`,
    `//fboss/agent/hw/test:hw_qos_utils`, and `//fboss/agent/hw/test:hw_test_fabric_utils`
    in exported_deps for link_tests

38. agent_ensemble_link_tests: Added trap_packet_utils and agent_test_utils
    fboss/agent/test/link_tests/BUCK has `//fboss/agent/test/utils:trap_packet_utils`
    and `//fboss/agent/test:utils` in exported_deps for agent_ensemble_link_tests

## Fixes in cmake/AgentTestUtils.cmake:

39. traffic_policy_utils: Added copp_test_utils
    fboss/agent/test/utils/BUCK has `:copp_test_utils` in exported_deps for traffic_policy_utils

40. qos_test_utils: Added voq_test_utils, resourcelibutil, and pkt_test_utils
    fboss/agent/test/utils/BUCK has `:voq_test_utils`, `//fboss/agent/test:resourcelibutil`,
    and `:pkt_test_utils` in exported_deps for qos_test_utils

41. l2learn_observer_util: Added agent_ensemble
    fboss/agent/test/utils/BUCK has `//fboss/agent/test:agent_ensemble`
    in exported_deps for l2learn_observer_util

42. mac_test_utils: Added core
    fboss/agent/test/utils/BUCK has `//fboss/agent:core` in exported_deps for mac_test_utils

43. pfc_test_utils: Added test_ensemble_if, agent_ensemble, and resourcelibutil
    fboss/agent/test/utils/BUCK has `//fboss/agent/test:test_ensemble_if`,
    `//fboss/agent/test:agent_ensemble`, and `//fboss/agent/test:resourcelibutil`
    in exported_deps for pfc_test_utils

## Fixes in cmake/LedService.cmake:

44. led_manager_lib: Added wedge400_fpga and common_port_utils
    fboss/led_service/BUCK has `//fboss/lib/fpga:wedge400_fpga` and
    `//fboss/lib:common_port_utils` in exported_deps for led_manager

## Fixes in cmake/Lib.cmake:

45. common_thrift_utils: Added thrift_service_client
    fboss/lib/BUCK has `//fboss/lib/thrift_service_client:thrift-service-client`
    in exported_deps for common_thrift_utils

46. common_utils: Added common_file_utils
    fboss/lib/BUCK has `:common_file_utils` in exported_deps for common_utils

## Fixes in cmake/LibFpga.cmake:

47. fpga_multi_pim_container: Added fpga_device and qsfp_stats
    fboss/lib/fpga/BUCK has `:fpga_device` and `//fboss/qsfp_service:stats`
    in exported_deps for multi_pim_container

48. fb_fpga_i2c: Added i2c_ctrl and i2_api
    fboss/lib/fpga/BUCK has `//fboss/lib/i2c:i2c_ctrl` and `//fboss/lib/usb:i2-api`
    in exported_deps for fb_fpga_i2c

49. wedge400_i2c: Added i2_api
    fboss/lib/fpga/BUCK has `//fboss/lib/usb:i2-api` in exported_deps for wedge400_i2c

## Fixes in cmake/LibI2c.cmake:

50. i2c_ctrl: Added utils
    fboss/lib/i2c/BUCK has `//fboss/agent:utils` in exported_deps for i2c_ctrl

## Fixes in cmake/LibPhy.cmake:

51. external_phy: Added mdio, alert_logger, and fboss_types
    fboss/lib/phy/BUCK has `//fboss/mdio:mdio`, `//fboss/lib:alert_logger`,
    and `//fboss/agent:fboss-types` in exported_deps for external_phy

## Fixes in cmake/PlatformBspTests.cmake:

52. bsp_test_utils: Added platform_manager_i2c_explorer
    fboss/platform/bsp_tests/BUCK has `//fboss/platform/platform_manager:i2c_explorer`
    in exported_deps for utils

## Fixes in cmake/PlatformPlatformChecks.cmake:

53. platform_check: Added platform_config_lib
    fboss/platform/platform_checks/BUCK has `//fboss/platform/config_lib:config_lib`
    in exported_deps for platform_check

## Fixes in cmake/PlatformPlatformManager.cmake:

54. platform_manager_i2c_explorer: Added platform_fs_utils
    fboss/platform/platform_manager/BUCK has `//fboss/platform/helpers:platform_fs_utils`
    in exported_deps for i2c_explorer

55. platform_manager_presence_checker: Added platform_fs_utils
    fboss/platform/platform_manager/BUCK has `//fboss/platform/helpers:platform_fs_utils`
    in exported_deps for presence_checker

## Fixes in cmake/QsfpService.cmake:

56-72. Added bsp_platform_mapping to 17 BSP targets:
    meru400bfu_bsp, meru400bia_bsp, meru400biu_bsp, meru800bia_bsp,
    meru800bfa_bsp, montblanc_bsp, icecube800bc_bsp, icetea800bc_bsp,
    minipack3n_bsp, morgan800cc_bsp, janga800bic_bsp, tahan800bc_bsp,
    tahansb800bc_bsp, nh4010_bsp, wedge800bact_bsp, wedge800cact_bsp,
    ladakh800bcls_bsp

    All these targets in fboss/lib/bsp/*/BUCK have `//fboss/lib/bsp:bsp_platform_mapping_lib`
    in exported_deps (example: fboss/lib/bsp/meru400bfu/BUCK has this for meru400bfu_bsp)

73. qsfp_stats: Added fboss_types
    fboss/qsfp_service/BUCK has `//fboss/agent:fboss-types` in exported_deps for stats

74. qsfp_bsp_core: Added gpiod_line and i2_api
    fboss/lib/bsp/BUCK has `//fboss/lib:gpiod_line` and `//fboss/lib/usb:i2-api`
    in exported_deps for bsp_core

75. transceiver_validator: Added alert_logger
    fboss/qsfp_service/BUCK has `//fboss/lib:alert_logger` in exported_deps
    for transceiver_validator

## Fixes in cmake/QsfpServiceTestHwTest.cmake:

76. hw_transceiver_utils: Added platform_mapping
    fboss/qsfp_service/test/hw_test/BUCK has `//fboss/agent/platforms/common:platform_mapping`
    in exported_deps for hw_transceiver_utils

## Fixes in cmake/ThriftCowVisitors.cmake:

77. thrift_cow_visitors: Added thrift_cow_serializer
    fboss/thrift_cow/visitors/BUCK has `//fboss/thrift_cow/nodes:serializer`
    in exported_deps for visitors

## Fixes in cmake/fsdb/FsdbClient.cmake:

78. fsdb_sub_mgr: Added fsdb_flags and thrift_service_client
    fboss/fsdb/client/BUCK has `//fboss/fsdb/common:flags` and
    `//fboss/lib/thrift_service_client:thrift-service-client` in exported_deps
    for fsdb_sub_manager

## Fixes in cmake/fsdb/FsdbIf.cmake:

79. fsdb_model_cpp2: Added fsdb_common_cpp2 to DEPENDS
    fboss/fsdb/if/oss/BUCK has `//fboss/fsdb/if:fsdb_common` in deps for fsdb_model

## Fixes in cmake/fsdb/FsdbOperInstantiations.cmake:

80. fsdb_cow_stats_sub_mgr: Added fsdb_cow_state_sub_mgr
    fboss/fsdb/client/BUCK (fsdb_cow_stats_sub_manager target) has
    `:fsdb_cow_state_sub_manager` in exported_deps

## Fixes in cmake/fsdb/FsdbServer.cmake:

81. fsdb_server: Added restart_time_tracker
    fboss/fsdb/server/BUCK has `//fboss/lib/restart_tracker:restart_time_tracker`
    in exported_deps for fsdb_server

## Fixes in cmake/fsdb/FsdbTests.cmake:

82. fsdb_test_subscriber: Changed fsdb_model_cpp2 to fsdb_model
    fboss/fsdb/tests/utils/BUCK has `//fboss/fsdb/if:fsdb_model` in exported_deps
    for fsdb_test_subscriber (fsdb_model includes both cpp2 types and thriftpath)

83. fsdb_test_clients: Changed fsdb_model_cpp2 to fsdb_model
    fboss/fsdb/tests/client/BUCK has `//fboss/fsdb/if:fsdb_model` in exported_deps
    for fsdb_test_clients

## New tool added:

`tools/buck_cmake_dep_checker.py` - A tool to detect missing dependencies
between Buck and cmake build systems by:
- Parsing BUCK and cmake files to extract targets and their dependencies
- Matching cmake targets to Buck targets based on source file overlap
- Identifying dependencies present in Buck but missing in cmake
- Supporting cmake variable expansion and transitive dependency analysis

Author: benoit-nexthop

cmake/Agent.cmake

@@ -10,6 +10,7 @@ add_library(setup_thrift
 
 target_link_libraries(setup_thrift
   load_agent_config
+  thrift_method_rate_limit
   Folly::folly
   FBThrift::thriftcpp2
 )
@@ -52,6 +53,7 @@ add_library(hw_switch_handler
 )
 
 target_link_libraries(hw_switch_handler
+  fboss_event_base
   load_agent_config
   switch_config_cpp2
   utils
@@ -96,6 +98,8 @@ target_link_libraries(switchinfo_utils
   ctrl_cpp2
   fboss_types
   agent_config_cpp2
+  fboss_error
+  load_agent_config
 )
 
 add_library(dsfnode_utils
@@ -146,6 +150,7 @@ target_link_libraries(utils
   asic_utils
   error
   ctrl_cpp2
+  hw_switch_fb303_stats
   load_agent_config
   state
   switchid_scope_resolver
@@ -174,6 +179,7 @@ add_library(stats
 target_link_libraries(stats
   fboss_types
   agent_stats_cpp2
+  common_utils
   state
   Folly::folly
 )
@@ -218,7 +224,10 @@ add_library(ecmp_resource_manager
 
 target_link_libraries(ecmp_resource_manager
   fib_helpers
+  ref_map
   state
+  stats
+  utils
   Folly::folly
 )
 
@@ -370,6 +379,7 @@ set(core_libs
   lldp
   multiswitch_ctrl_cpp2
   packet
+  packet_factory
   product_info
   platform_base
   restart_time_tracker
@@ -475,6 +485,7 @@ add_library(fboss_event_base
 )
 
 target_link_libraries(fboss_event_base
+  agent_features
   Folly::folly
 )
 
@@ -504,12 +515,15 @@ target_link_libraries(platform_base
   agent_dir_util
   ctrl_cpp2
   error
+  fboss_event_base
   fboss_types
   Folly::folly
   load_agent_config
   platform_mapping
+  product_info
   switchid_scope_resolver
   switchinfo_utils
+  utils
 )
 
 add_library(hw_switch
@@ -828,7 +842,9 @@ add_library(agent_netwhoami
   fboss/agent/oss/AgentNetWhoAmI.cpp
 )
 
-target_link_libraries(agent_netwhoami)
+target_link_libraries(agent_netwhoami
+  common_file_utils
+)
 
 add_library(agent_features
   fboss/agent/AgentFeatures.cpp

cmake/AgentHw.cmake

@@ -84,15 +84,18 @@ target_link_libraries(hw_switch_fb303_stats
 
 target_link_libraries(hw_fb303_stats
   counter_utils
+  error
   fb303::fb303
   Folly::folly
   switch_config_cpp2
 )
 
 target_link_libraries(hw_port_fb303_stats
   counter_utils
+  fboss_types
   FBThrift::thriftcpp2
   hardware_stats_cpp2
+  hw_fb303_stats
   Folly::folly
 )
 

cmake/AgentHwMock.cmake

@@ -22,6 +22,7 @@ add_library(hw_mock
 
 target_link_libraries(hw_mock
   core
+  handler
   pkt
   Folly::folly
   ${GTEST}

cmake/AgentHwSaiHwTest.cmake

@@ -191,6 +191,7 @@ add_library(agent_hw_test_thrift_handler
 )
 
 target_link_libraries(agent_hw_test_thrift_handler
+  hw_switch
   sai_switch # //fboss/agent/hw/sai/switch:sai_switch
   acl_test_utils
   agent_hw_test_ctrl_cpp2

cmake/AgentHwSwitchAsics.cmake

@@ -31,7 +31,10 @@ add_library(switch_asics
 )
 
 target_link_libraries(switch_asics
+  agent_features
+  error
   fboss_cpp2
+  fboss_types
   phy_cpp2
   switch_config_cpp2
   version_util

cmake/AgentHwTest.cmake

@@ -17,6 +17,7 @@ add_library(config_factory
 )
 
 target_link_libraries(config_factory
+  acl_test_utils
   config_utils
   fboss_types
   hw_switch
@@ -26,6 +27,8 @@ target_link_libraries(config_factory
   fboss_config_utils
   port_test_utils
   linkstate_toggler
+  split_agent_thrift_syncer
+  multiswitch_test_server
 )
 
 add_library(hw_test_main
@@ -47,6 +50,7 @@ add_library(hw_packet_utils
 )
 
 target_link_libraries(hw_packet_utils
+  agent_test_utils
   hw_switch_ensemble
   packet_factory
   packet_snooper
@@ -77,6 +81,8 @@ add_library(hw_copp_utils
 )
 
 target_link_libraries(hw_copp_utils
+  copp_test_utils
+  hw_packet_utils
   hw_test_acl_utils
   switch_asics
   packet_factory
@@ -136,6 +142,7 @@ target_link_libraries(hw_link_state_toggler
   core
   switch_config_cpp2
   state
+  test_ensemble_if
   Folly::folly
 )
 
@@ -174,6 +181,7 @@ add_library(load_balancer_utils
 target_link_libraries(load_balancer_utils
   fboss_types
   hw_switch
+  load_balancer_test_utils
   platform_base
   switch_asics
   state

cmake/AgentLldp.cmake

@@ -18,6 +18,8 @@ add_library(lldp
 )
 
 target_link_libraries(lldp
+  agent_features
+  cow_storage
   fboss_types
   lldp_structs_cpp2
   Folly::folly

cmake/AgentPacket.cmake

@@ -58,6 +58,7 @@ add_library(packet_factory
 )
 
 target_link_libraries(packet_factory
+  hw_switch
   packet
   ctrl_cpp2
   switch_config_cpp2

cmake/AgentPlatformsCommon.cmake

@@ -54,5 +54,6 @@ target_link_libraries(platform_mapping_utils
   tahansb800bc_platform_mapping
   wedge800cact_platform_mapping
   ladakh800bcls_platform_mapping
+  platform_mode
   ${RE2}
 )

cmake/AgentPlatformsCommonGalaxy.cmake

@@ -12,5 +12,6 @@ add_library(galaxy_platform_mapping
 
 target_link_libraries(galaxy_platform_mapping
   platform_mapping
+  utils
   Folly::folly
 )