Speed up fboss2 CLI unit tests.

Tests using the mocked agent connection would often incur a 5-7 second
delay because of the default Thrift configuration. By being more
aggressive we can speed up the tests significantly. The 25 unit tests
now take about 20-22s to complete (I’ve seen as low as 11s) vs 125-135s
before (testing on Intel Xeon Silver 4309Y @ 2.80GHz).

Author: benoit-nexthop

fboss/cli/fboss2/test/CmdHandlerTestBase.h

@@ -3,6 +3,7 @@
 #include <gtest/gtest.h>
 
 #include <folly/IPAddressV4.h>
+#include <thrift/lib/cpp2/server/ThriftServer.h>
 #include <thrift/lib/cpp2/util/ScopedServerInterfaceThread.h>
 #include <memory>
 #include "fboss/cli/fboss2/CmdGlobalOptions.h"
@@ -23,17 +24,26 @@ class CmdHandlerTestBase : public ::testing::Test {
         "test.host", "test-oob.host", folly::IPAddressV6("::1"));
   }
 
+  // Helper to create server config with short idle timeout to avoid 5-7 second
+  // delays in test responses. Without this, the default idle timeout causes
+  // the server to wait before sending responses back to the client.
+  static auto createFastMockServerConfig() {
+    return [](apache::thrift::ThriftServer& server) {
+      server.setIdleTimeout(std::chrono::milliseconds(50));
+    };
+  }
+
   void setupMockedAgentServer() {
     mockedAgentServer_ =
         std::make_unique<apache::thrift::ScopedServerInterfaceThread>(
-            mockedAgent_);
+            mockedAgent_, createFastMockServerConfig());
     // set global agent thrift port to the fake server created on localhost
     CmdGlobalOptions::getInstance()->setAgentThriftPort(
         mockedAgentServer_->getAddress().getPort());
 
     mockedQsfpServer_ =
         std::make_unique<apache::thrift::ScopedServerInterfaceThread>(
-            mockedQsfpService_);
+            mockedQsfpService_, createFastMockServerConfig());
     // set global agent thrift port to the fake server created on localhost
     CmdGlobalOptions::getInstance()->setQsfpThriftPort(
         mockedQsfpServer_->getAddress().getPort());
@@ -43,7 +53,7 @@ class CmdHandlerTestBase : public ::testing::Test {
 #ifndef IS_OSS
     mockedBgpServer_ =
         std::make_unique<apache::thrift::ScopedServerInterfaceThread>(
-            mockedBgpService_);
+            mockedBgpService_, createFastMockServerConfig());
     CmdGlobalOptions::getInstance()->setBgpThriftPort(
         mockedBgpServer_->getAddress().getPort());
 #endif

fboss/cli/fboss2/test/CmdShowHostTest.cpp

@@ -44,16 +44,9 @@ std::vector<NdpEntryThrift> createMockNdpEntries() {
   ndpEntry2.port() = 1;
   ndpEntry2.classID() = 0;
 
-  NdpEntryThrift ndpEntry3;
-  folly::IPAddressV6 ipv6_3("2401:db00:e13d:846::41");
-  network::thrift::BinaryAddress binaryAddr3 =
-      facebook::network::toBinaryAddress(ipv6_3);
-
-  ndpEntry3.ip() = binaryAddr3;
-  ndpEntry3.port() = 51;
-  ndpEntry3.classID() = 0;
-
-  std::vector<NdpEntryThrift> entries{ndpEntry1, ndpEntry2, ndpEntry3};
+  // Only return entries that will be in the final model to avoid unnecessary
+  // DNS lookups during tests
+  std::vector<NdpEntryThrift> entries{ndpEntry1, ndpEntry2};
   return entries;
 }