Auto-populate XPHY backplane port overrides from qsfpTestConfig

Summary:
When FLAGS_override_program_iphy_ports_for_test is set, WedgeManager auto-populates overrideTcvrToPortAndProfileForTest_ from qsfpTestConfig for ports WITH transceivers. This change adds the equivalent functionality in PortManager for ports WITHOUT transceivers but WITH XPHY.

Changes:
1. Added setOverrideXphyNoTcvrPortToProfileForTesting() call in PortManager::init()
2. Added the logic in setOverrideXphyNoTcvrPortToProfileForTesting() that reads cabledPortPairs from qsfpTestConfig and adds ports that does not have a transiever but has xphy

** Also removed the else branch from setOverrideXphyNoTcvrPortToProfileForTesting() that cleared the port-to-profile override map when called without arguments and FLAGS_override_program_iphy_ports_for_test was not set.  This was causing unit tests to fail because they set up the override map first, then PortManager::init() would call this function without arguments and clear the previously-set mappings. This aligns with WedgeManager::setOverrideTcvrToPortAndProfileForTesting() which also doesn't have an else branch that clears its override map.

Reviewed By: shiva-menta

Differential Revision: D91012058

fbshipit-source-id: f2e1c7517870505a528dbc3c4e2796b2a9526a62

Author: Protick Bhowmick

fboss/qsfp_service/BUCK

@@ -273,6 +273,7 @@ cpp_library(
     compiler_flags = QSFP_COMMON_COMPILER_FLAGS,
     exported_deps = [
         "fbsource//third-party/fmt:fmt",
+        ":qsfp-config",
         ":qsfp-service-threads",
         ":transceiver-manager",
         "//fboss/agent:fboss-error",

fboss/qsfp_service/PortManager.cpp

@@ -5,6 +5,7 @@
 #include <folly/json/DynamicConverter.h>
 #include "fboss/agent/Utils.h"
 #include "fboss/lib/thrift_service_client/ThriftServiceClient.h"
+#include "fboss/qsfp_service/QsfpConfig.h"
 
 namespace facebook::fboss {
 namespace {
@@ -178,6 +179,11 @@ void PortManager::init() {
   if (transceiverManager_->canWarmBoot()) {
     restoreAgentConfigAppliedInfo();
   }
+  // Set overrideXphyNoTcvrPortToProfileForTest_ if
+  // FLAGS_override_program_iphy_ports_for_test is true.
+  // This mirrors what WedgeManager::initTransceiverMap() does for
+  // overrideTcvrToPortAndProfileForTest_.
+  setOverrideXphyNoTcvrPortToProfileForTesting();
 
   initExternalPhyMap();
 }
@@ -890,8 +896,23 @@ void PortManager::setOverrideXphyNoTcvrPortToProfileForTesting(
         overrideXphyNoTcvrPortToProfile) {
   if (overrideXphyNoTcvrPortToProfile.has_value()) {
     overrideXphyNoTcvrPortToProfileForTest_ = *overrideXphyNoTcvrPortToProfile;
-  } else {
-    overrideXphyNoTcvrPortToProfileForTest_.clear();
+  } else if (FLAGS_override_program_iphy_ports_for_test) {
+    auto qsfpTestConfig =
+        transceiverManager_->getQsfpConfig()->thrift.qsfpTestConfig();
+    CHECK(qsfpTestConfig.has_value());
+    for (const auto& portPairs : *qsfpTestConfig->cabledPortPairs()) {
+      auto aPortID = getPortIDByPortName(*portPairs.aPortName());
+      auto zPortID = getPortIDByPortName(*portPairs.zPortName());
+      // If the SW port does NOT have a transceiver but HAS XPHY, add it to
+      // overrideXphyNoTcvrPortToProfileForTest_ (XPHY backplane port)
+      for (const auto& portID : {aPortID, zPortID}) {
+        if (portID.has_value() && !portHasTransceiver(*portID) &&
+            cachedXphyPorts_.find(*portID) != cachedXphyPorts_.end()) {
+          overrideXphyNoTcvrPortToProfileForTest_.emplace(
+              *portID, *portPairs.profileID());
+        }
+      }
+    }
   }
 }
 

fboss/qsfp_service/PortManager.h

@@ -23,6 +23,8 @@
 #include "fboss/qsfp_service/TransceiverManager.h"
 #include "fboss/qsfp_service/if/gen-cpp2/transceiver_types.h"
 
+DECLARE_bool(override_program_iphy_ports_for_test);
+
 #define TYPED_LOG(level, logType) XLOG(level) << logType << " "
 
 #define PORTMGR_SM_LOG(level) TYPED_LOG(level, "[SM]")

fboss/qsfp_service/TransceiverManager.cpp

@@ -75,6 +75,11 @@ DEFINE_bool(
     false,
     "Set to true to enable Port Manager mode. This means PortManager object will manage all port-level logic and TransceiverManager object will only manage transceiver-level logic.");
 
+DEFINE_bool(
+    override_program_iphy_ports_for_test,
+    false,
+    "Override wedge_agent programInternalPhyPorts(). For test only");
+
 namespace {
 constexpr auto kFbossPortNameRegex = "(eth|fab)(\\d+)/(\\d+)/(\\d+)";
 constexpr auto kForceColdBootFileName = "cold_boot_once_qsfp_service";

fboss/qsfp_service/platforms/wedge/WedgeManager.cpp

@@ -24,11 +24,6 @@
 #include <thrift/lib/cpp/util/EnumUtils.h>
 #include <chrono>
 
-DEFINE_bool(
-    override_program_iphy_ports_for_test,
-    false,
-    "Override wedge_agent programInternalPhyPorts(). For test only");
-
 DEFINE_bool(
     optics_data_post_to_rest,
     false,