Skip to content

Commit bb1eb75

Browse files
tsaichienfacebook-github-bot
authored andcommitted
Fix SynthTraceSerializationTest for Windows (#1577)
Summary: Pull Request resolved: #1577 MSVC has stringizing bug where it doesn't process code units in raw string literals. See example: https://godbolt.org/z/osjYj95rq Temporary fix is to move the string literal out of the `EXPECT_EQ` macro until this gets fixed. Reviewed By: neildhar Differential Revision: D66914807 fbshipit-source-id: 947d4f2254d23ee322dcc063b40f8d05575987d1
1 parent 40c2e97 commit bb1eb75

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

unittests/API/SynthTraceSerializationTest.cpp

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,23 +396,31 @@ TEST_F(SynthTraceSerializationTest, Utf8Record) {
396396
}
397397

398398
TEST_F(SynthTraceSerializationTest, Utf16Record) {
399+
auto serialized =
400+
R"({"type":"Utf16Record","time":0,"objID":"string:123","retval":"hi\ud83d\udc4b"})";
399401
EXPECT_EQ(
400-
R"({"type":"Utf16Record","time":0,"objID":"string:123","retval":"hi\ud83d\udc4b"})",
402+
serialized,
401403
to_string(SynthTrace::Utf16Record(
402404
dummyTime, SynthTrace::encodeString(123), u"hi👋")));
405+
serialized =
406+
R"({"type":"Utf16Record","time":0,"objID":"string:111","retval":"\ud83d"})";
403407
EXPECT_EQ(
404-
R"({"type":"Utf16Record","time":0,"objID":"string:111","retval":"\ud83d"})",
408+
serialized,
405409
to_string(SynthTrace::Utf16Record(
406410
dummyTime, SynthTrace::encodeString(111), u"\xd83d")));
407411
}
408412

409413
TEST_F(SynthTraceSerializationTest, GetStringDataRecord) {
414+
auto serialized =
415+
R"({"type":"GetStringDataRecord","time":0,"objID":"string:123","strData":"\nhello\ud83d\udc4b\\"})";
410416
EXPECT_EQ(
411-
R"({"type":"GetStringDataRecord","time":0,"objID":"string:123","strData":"\nhello\ud83d\udc4b\\"})",
417+
serialized,
412418
to_string(SynthTrace::GetStringDataRecord(
413419
dummyTime, SynthTrace::encodeString(123), u"\nhello👋\\")));
420+
serialized =
421+
R"({"type":"GetStringDataRecord","time":0,"objID":"propNameID:111","strData":"\ud83d"})";
414422
EXPECT_EQ(
415-
R"({"type":"GetStringDataRecord","time":0,"objID":"propNameID:111","strData":"\ud83d"})",
423+
serialized,
416424
to_string(SynthTrace::GetStringDataRecord(
417425
dummyTime, SynthTrace::encodePropNameID(111), u"\xd83d")));
418426
}

0 commit comments

Comments
 (0)