Add compatibility checking for flash procedure

Summary:
We recently encounter issues where minipack3n cannot be flashed. Turned out there is no flash procedure found for this platform. This is because we only have "acctonbmc" flash procedure. This happens because we sync the configerator and create the mapping based on build_name

One way to solve this issue is also to check the compatible mapping of the original build name, and check whether the compatible platform has any flash procedure

Another long term solution probably also sync the mapping between `acctonbmc -> ["minipack3n", "minipack3ba", "wedge800"]`. For now, I propose to use this simple solution

Test Plan:
# unit test
{P2141569386}

 ---
# functional test
- build flashy locally
{P2141574929}
- run oobgrader using flashy
```
 oobgrader --host fboss329039396.snc1.facebook.com --wait --ui --method fbpkg --flashy-tag 034f55c --force --allow-downgrade
```

https://fburl.com/scuba/openbmc_upgrades/7selm40a

Reviewed By: kawmarco

Differential Revision: D91321314

fbshipit-source-id: 8dfbab6e05cb0c51f34b541031b6cd3faaf41dd4

Author: malikrafsan

tools/flashy/flash_procedure/platform_registry.go

@@ -21,9 +21,11 @@ package flash_procedure
 
 import (
 	"fmt"
+	"log"
 
 	"github.com/facebook/openbmc/tools/flashy/lib/flash"
 	"github.com/facebook/openbmc/tools/flashy/lib/step"
+	"github.com/facebook/openbmc/tools/flashy/lib/validate"
 )
 
 var procedureOverrides = map[string]func(step.StepParams) step.StepExitError{
@@ -42,6 +44,22 @@ func init() {
 			FlashProcedureMappings[platformName] = overrideFunc
 		}
 	}
+
+	for platformName, compatiblePlatformName := range validate.CompatibleVersionMapping {
+		_, exists := FlashProcedureMappings[platformName]
+		if exists {
+			// prevent overriding existing mappings (eg: in case any override)
+			continue
+		}
+
+		_, exists = FlashProcedureMappings[compatiblePlatformName]
+		if !exists {
+			log.Printf("WARNING: compatible platform name '%s' not present in flash procedure mapping", compatiblePlatformName)
+			continue
+		}
+
+		FlashProcedureMappings[platformName] = FlashProcedureMappings[compatiblePlatformName]
+	}
 }
 
 func PlatformExists(platformName string) bool {

tools/flashy/lib/validate/compatibility.go

@@ -35,7 +35,7 @@ import (
 // matches all possible formats would be tough. Instead, we use this to do
 // substitutions before matching in areVersionsCompatible().
 // NB: the values of this mapping CANNOT contain a dash!
-var compatibleVersionMapping = map[string]string{
+var CompatibleVersionMapping = map[string]string{
 	"fby2-gpv2":  "fbgp2",
 	"fby3pvt":    "fby3",
 	"fby3vboot2": "fby3",
@@ -47,7 +47,7 @@ var compatibleVersionMapping = map[string]string{
 }
 
 var normalizeVersion = func(ver string) string {
-	for k, v := range compatibleVersionMapping {
+	for k, v := range CompatibleVersionMapping {
 		ver = strings.Replace(ver, k, v, 1)
 	}
 	return ver
@@ -96,7 +96,7 @@ var CheckImageBuildNameCompatibility = func(imageFilePath string) error {
 }
 
 // getNormalizedBuildNameFromVersion gets the normalized build name from the version using
-// compatibleVersionMapping.
+// CompatibleVersionMapping.
 // fby2-gpv2-v2019.43.1 -> fbgp2
 // yosemite-v1.2 -> yosemite
 var getNormalizedBuildNameFromVersion = func(ver string) (string, error) {

tools/flashy/lib/validate/compatibility_test.go

@@ -30,8 +30,8 @@ import (
 )
 
 func TestCompatibleVersionMapping(t *testing.T) {
-	// the values of compatibleVersionMapping cannot have a dash
-	for key, val := range compatibleVersionMapping {
+	// the values of CompatibleVersionMapping cannot have a dash
+	for key, val := range CompatibleVersionMapping {
 		if strings.ContainsAny(val, "-") {
 			t.Errorf("Invalid mapping (%v, %v), value %v cannot contain a dash",
 				key, val, val)
@@ -42,11 +42,11 @@ func TestCompatibleVersionMapping(t *testing.T) {
 func TestCheckImageBuildNameCompatibility(t *testing.T) {
 	getOpenBMCVersionFromIssueFileOrig := utils.GetOpenBMCVersionFromIssueFile
 	getOpenBMCVersionFromImageFileOrig := GetOpenBMCVersionFromImageFile
-	compatibleVersionMappingOrig := compatibleVersionMapping
+	CompatibleVersionMappingOrig := CompatibleVersionMapping
 	defer func() {
 		utils.GetOpenBMCVersionFromIssueFile = getOpenBMCVersionFromIssueFileOrig
 		GetOpenBMCVersionFromImageFile = getOpenBMCVersionFromImageFileOrig
-		compatibleVersionMapping = compatibleVersionMappingOrig
+		CompatibleVersionMapping = CompatibleVersionMappingOrig
 	}()
 
 	cases := []struct {
@@ -105,7 +105,7 @@ func TestCheckImageBuildNameCompatibility(t *testing.T) {
 		},
 	}
 
-	compatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2"}
+	CompatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2"}
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {
 			exampleImageFilePath := "/run/upgrade/mock"
@@ -126,9 +126,9 @@ func TestCheckImageBuildNameCompatibility(t *testing.T) {
 
 // also tests normalizeVersion
 func TestGetNormalizedBuildNameFromVersion(t *testing.T) {
-	compatibleVersionMappingOrig := compatibleVersionMapping
+	CompatibleVersionMappingOrig := CompatibleVersionMapping
 	defer func() {
-		compatibleVersionMapping = compatibleVersionMappingOrig
+		CompatibleVersionMapping = CompatibleVersionMappingOrig
 	}()
 
 	cases := []struct {
@@ -182,7 +182,7 @@ func TestGetNormalizedBuildNameFromVersion(t *testing.T) {
 		},
 	}
 
-	compatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2", "minipack3n": "acctonbmc", "icecube800bc": "celesticabmc"}
+	CompatibleVersionMapping = map[string]string{"fby2-gpv2": "fbgp2", "minipack3n": "acctonbmc", "icecube800bc": "celesticabmc"}
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {
 			got, err := getNormalizedBuildNameFromVersion(tc.ver)