Skip to content

Commit

Permalink
Remove unused-but-set variables in proxygen/lib/http/session/HTTPSess…
Browse files Browse the repository at this point in the history
…ion.cpp +1

Summary:
Required for LLVM-19 upgrade.

This diff removes a variable that was set, but which was not used.

LLVM-19 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.

Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.

For questions/comments, contact r-barnes.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: hanidamlaj

Differential Revision: D64996211

fbshipit-source-id: db6b587bd9ff7662577f6aaac2ace6dc461cecfc
  • Loading branch information
r-barnes authored and facebook-github-bot committed Oct 26, 2024
1 parent 0246ae3 commit f6ce4ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proxygen/lib/http/session/HTTPSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ void HTTPSession::onHeadersComplete(HTTPCodec::StreamID streamID,
// Inform observers when request headers (i.e. ingress, from downstream
// client) are processed.
if (isDownstream()) {
if (auto msgPtr = msg.get()) {
if (msg.get()) {
const auto event =
HTTPSessionObserverInterface::RequestStartedEvent::Builder()
.setTimestamp(HTTPSessionObserverInterface::Clock::now())
Expand Down

0 comments on commit f6ce4ad

Please sign in to comment.