remove now unused mEndBackground Drawable and explicitly compare long colors

Author: ryanlntn

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java

@@ -96,7 +96,6 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
   private boolean mSendMomentumEvents;
   private @Nullable FpsListener mFpsListener = null;
   private @Nullable String mScrollPerfTag;
-  private @Nullable Drawable mEndBackground;
   private long mEndFillColor = Color.pack(Color.TRANSPARENT);
   private boolean mDisableIntervalMomentum = false;
   private int mSnapInterval = 0;
@@ -784,7 +783,6 @@ private View getContentView() {
   public void setEndFillColor(long color) {
     if (color != mEndFillColor) {
       mEndFillColor = color;
-      mEndBackground = new ColorDrawable(mEndFillColor);
     }
   }
 
@@ -856,7 +854,7 @@ private boolean isScrollPerfLoggingEnabled() {
 
   @Override
   public void draw(Canvas canvas) {
-    if (mEndFillColor != Color.TRANSPARENT) {
+    if (mEndFillColor != Color.pack(Color.TRANSPARENT)) {
       final View content = getContentView();
       if (content != null && content.getRight() < getWidth()) {
         Paint paint = new Paint();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java

@@ -97,7 +97,6 @@ public class ReactScrollView extends ScrollView
   private boolean mSendMomentumEvents;
   private @Nullable FpsListener mFpsListener = null;
   private @Nullable String mScrollPerfTag;
-  private @Nullable Drawable mEndBackground;
   private long mEndFillColor = Color.pack(Color.TRANSPARENT);
   private boolean mDisableIntervalMomentum = false;
   private int mSnapInterval = 0;
@@ -621,7 +620,7 @@ public void setStateWrapper(StateWrapper stateWrapper) {
 
   @Override
   public void draw(Canvas canvas) {
-    if (mEndFillColor != Color.TRANSPARENT) {
+    if (mEndFillColor != Color.pack(Color.TRANSPARENT)) {
       final View contentView = getContentView();
       if (contentView != null && contentView.getBottom() < getHeight()) {
         Paint paint = new Paint();
@@ -1008,7 +1007,6 @@ private int getSnapInterval() {
   public void setEndFillColor(long color) {
     if (color != mEndFillColor) {
       mEndFillColor = color;
-      mEndBackground = new ColorDrawable(mEndFillColor);
     }
   }