-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline syntax errors to website editor #11094
Comments
We use the cc @philpl for thoughts 😄 |
@bvaughn I’d be super up for it! 😲 The biggest conflict I see is with adding custom transpilers. The implementation of this feature might vary slightly depending on what transpiler is used unfortunately 🤐 Also the site is currently using a fully custom transpiler on top of Babel-standalone. But once we reconcile these problems, I’m sure it’s not too hard to add |
Maybe there's a custom format we could define that would enable the user to inject error messages with a row and (optional) column number that would be sufficiently compiler-agnostic? type compilationErrors = Array<{
message: string,
rowNumber: number,
columnNumber?: number
}> |
@bvaughn that'd be great! Could just be added to the Editor without much effort. Not sure how soon I'll have time for this. Do you mind copying this issue with the suggested API over into an issue on react-live please? :) |
You got it! FormidableLabs/react-live/issues/41 |
Moved to reactjs/react.dev/issues/10 |
@tsriram suggested a proof of concept in
I like that. I wonder if we can do it with the new editor.
The text was updated successfully, but these errors were encountered: