Skip to content

Commit ffff7ab

Browse files
committed
Fix Abseil CMake package name
It's "absl" not "abseil". If we use "abseil", -Dabseil_SOURCE=SYSTEM is never succeeded because abseilConfig.cmake doesn't exist.
1 parent b65acf4 commit ffff7ab

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,20 @@ include_guard(GLOBAL)
33
# TODO: these variables are named VELOX_* because we are piggy-backing on
44
# Velox's resolve dependency module for now. We should change and have our own
55
# in the future.
6-
set(VELOX_ABSEIL_VERSION 20240116.0)
7-
set(VELOX_ABSEIL_BUILD_SHA256_CHECKSUM
6+
set(VELOX_ABSL_VERSION 20240116.0)
7+
set(VELOX_ABSL_BUILD_SHA256_CHECKSUM
88
"338420448b140f0dfd1a1ea3c3ce71b3bc172071f24f4d9a57d59b45037da440")
9-
set(VELOX_ABSEIL_SOURCE_URL
10-
"https://github.com/abseil/abseil-cpp/archive/refs/tags/${VELOX_ABSEIL_VERSION}.tar.gz"
9+
set(VELOX_ABSL_SOURCE_URL
10+
"https://github.com/abseil/abseil-cpp/archive/refs/tags/${VELOX_ABSL_VERSION}.tar.gz"
1111
)
1212

13-
velox_resolve_dependency_url(ABSEIL)
13+
velox_resolve_dependency_url(ABSL)
1414

15-
message(STATUS "Building abseil from source")
15+
message(STATUS "Building Abseil from source")
1616

1717
FetchContent_Declare(
18-
abseil
19-
URL ${VELOX_ABSEIL_SOURCE_URL}
20-
URL_HASH ${VELOX_ABSEIL_BUILD_SHA256_CHECKSUM})
18+
absl
19+
URL ${VELOX_ABSL_SOURCE_URL}
20+
URL_HASH ${VELOX_ABSL_BUILD_SHA256_CHECKSUM})
2121

22-
FetchContent_MakeAvailable(abseil)
22+
FetchContent_MakeAvailable(absl)

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ velox_resolve_dependency(Boost 1.77.0 COMPONENTS ${BOOST_INCLUDE_LIBRARIES})
115115
velox_set_source(folly)
116116
velox_resolve_dependency(folly)
117117

118-
velox_set_source(abseil)
119-
velox_resolve_dependency(abseil)
118+
velox_set_source(absl)
119+
velox_resolve_dependency(absl)
120120

121121
# Use xxhash and xsimd from Velox for now.
122122
include_directories(.)

0 commit comments

Comments
 (0)