Skip to content

Commit 492b70b

Browse files
kittipatvfacebook-github-bot
authored andcommitted
CI instructions
Summary: Add a page for CI instructions Reviewed By: czxttkl Differential Revision: D17983742 fbshipit-source-id: 31479a349310a55844cea7ea97629fcd96d5b1b6
1 parent be985fb commit 492b70b

File tree

5 files changed

+29
-9
lines changed

5 files changed

+29
-9
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Contributing to Horizon
1+
# Contributing to ReAgent
22
We want to make contributing to this project as easy and transparent as
33
possible.
44

@@ -23,5 +23,5 @@ We use GitHub issues to track public bugs. Please ensure your description is
2323
clear and has sufficient instructions to be able to reproduce the issue.
2424

2525
## License
26-
By contributing Horizon, you agree that your contributions will be licensed
26+
By contributing ReAgent, you agree that your contributions will be licensed
2727
under the LICENSE file in the root directory of this source tree.

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BSD License
22

3-
For Horizon software
3+
For ReAgent software
44

55
Copyright (c) 2017-present, Facebook, Inc. All rights reserved.
66

docs/conf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
# -- Project information -----------------------------------------------------
2222

2323

24-
project = "Horizon"
24+
project = "ReAgent"
2525
copyright = "2019, Facebook Inc."
26-
author = "Horizon Team"
26+
author = "ReAgent Team"
2727

2828
# The full version, including alpha/beta/rc tags
2929
release = "1.0"

docs/continuous_integration.rst

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
.. _continuous_integration:
2+
3+
Continuous Integration
4+
======================
5+
6+
We have CI setup on `CircleCI <https://circleci.com/gh/facebookresearch/ReAgent>`_.
7+
It's a pretty basic setup. One key thing to note is that dependencies are baked into our Docker images.
8+
If you need a new dependency, you will have to rebuild Docker images, upload them to Docker hub, and update ``.circleci/config.yml`` accordingly.
9+
Here are the steps:
10+
11+
.. code-block::
12+
docker build -f docker/cpu.Dockerfile -t reagent:cpu .
13+
docker tag reagent:cpu kittipatv/reagent:cpu_test
14+
docker push kittipatv/reagent:cpu_test
15+
16+
If you cannot push, you have to run ``docker login``.
17+
18+
Then, you should follow the local testing instructions in ``.circleci/config.yml`` to make sure that the new Docker image is in a good shape.
19+
Once you are sure, tag the image without ``_test`` suffix and push again.
20+
If you weren't the last person to update the images, then you will have to submit a PR to update the image names.

docs/index.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ ReAgent: Applied Reinforcement Learning Platform
1111
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1212

1313

14-
.. image:: https://ci.pytorch.org/jenkins/buildStatus/icon?job=horizon-master
15-
:target: https://ci.pytorch.org/jenkins/job/horizon-master/
16-
:alt: Build Status
14+
.. image:: https://circleci.com/gh/facebookresearch/ReAgent/tree/master.svg?style=svg
15+
:target: https://circleci.com/gh/facebookresearch/ReAgent/tree/master
1716

1817
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
1918

@@ -26,7 +25,7 @@ workflows to train popular deep RL algorithms and includes data preprocessing, f
2625
counterfactual policy evaluation, and optimized serving. For more detailed information about ReAgent see the white
2726
paper here: `Platform <https://research.fb.com/publications/horizon-facebooks-open-source-applied-reinforcement-learning-platform/>`_.
2827

29-
The source code is available here: `Source code <https://github.com/facebookresearch/Horizon>`_.
28+
The source code is available here: `Source code <https://github.com/facebookresearch/ReAgent>`_.
3029

3130
The platform was once named "Horizon" but we have adopted the name "ReAgent" recently to emphasize its broader scope in decision making and reasoning.
3231

@@ -83,6 +82,7 @@ Table of Contents
8382
:caption: Advanced Topics
8483

8584
Distributed Training <distributed>
85+
Continuous Integration <continuous_integration>
8686

8787
.. toctree::
8888
:caption: Package Reference

0 commit comments

Comments
 (0)