Skip to content

Commit 4a53708

Browse files
committed
Allow monotonic rejection GP to initialize its inducing point allocator from config. (#485)
Summary: Pull Request resolved: #485 Monotonic rejection GP used to completely ignore any inducing point config, now it follows other models. Reviewed By: crasanders Differential Revision: D67225873 fbshipit-source-id: 843d4a129e81ac8b2f3fb4b3b63e6d24bd51e3a5
1 parent 04af42f commit 4a53708

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

aepsych/models/monotonic_rejection_gp.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,9 @@ def __init__(
9696
dim=self.dim
9797
)
9898

99-
# TODO: This allocator *must* be SobolAllocator and not the set one. This
100-
# suggests that this model doesn't actually properly use data for inducing
101-
# points properly.
102-
inducing_points = SobolAllocator(
103-
bounds=torch.stack([lb, ub]), dim=self.dim
104-
).allocate_inducing_points(num_inducing=self.inducing_size)
99+
inducing_points = self.inducing_point_method.allocate_inducing_points(
100+
num_inducing=self.inducing_size
101+
)
105102

106103
inducing_points_aug = self._augment_with_deriv_index(inducing_points, 0)
107104
variational_distribution = CholeskyVariationalDistribution(

0 commit comments

Comments
 (0)