Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROS node init issue in base_env, its parent & its children #115

Open
KavitShah1998 opened this issue Dec 16, 2023 · 1 comment
Open

Fix ROS node init issue in base_env, its parent & its children #115

KavitShah1998 opened this issue Dec 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@KavitShah1998
Copy link
Contributor

The issue is that SpotRobotSubscriberMixin which is absolute base class is the one that initializes ros node.

SpotBaseEnv, SpotNavEnv, SpotGazeEnv, SpotPlaceEnv keep modifying the ros node name which finally get's initialized in SpotRobotSubscriberMixin. This system is prone to bug because SpotSkillManager which does not inherit from any of these above mentioned classes will not be able to alter the node name and the file that utilizes SpotSkillManager cannot have a separate ros node init as that raises runtime error.
@KavitShah1998 KavitShah1998 added the enhancement New feature or request label Dec 16, 2023
@KavitShah1998
Copy link
Contributor Author

This has been discussed with @zephirefaith

@KavitShah1998 KavitShah1998 mentioned this issue Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KavitShah1998