Cleanup

Author: falahati

WindowsFirewallHelper.Sample/EditPortForm.cs

@@ -18,35 +18,50 @@ public FirewallProtocol FirewallProtocol
                 switch (cb_protocol.Text?.ToUpper().Trim())
                 {
                     case "ALL":
+
                         return FirewallProtocol.Any;
                     case "TCP":
+
                         return FirewallProtocol.TCP;
                     case "UDP":
+
                         return FirewallProtocol.UDP;
                     default:
                         FirewallProtocol protocol;
+
                         if (FirewallProtocol.TryParse(cb_protocol.Text, out protocol))
+                        {
                             return protocol;
+                        }
+
                         return null;
                 }
             }
             set
             {
                 if (value == FirewallProtocol.Any)
+                {
                     cb_protocol.SelectedItem = "ALL";
+                }
                 else if (value == FirewallProtocol.TCP)
+                {
                     cb_protocol.SelectedItem = "TCP";
+                }
                 else if (value == FirewallProtocol.UDP)
+                {
                     cb_protocol.SelectedItem = "UDP";
+                }
                 else
+                {
                     cb_protocol.SelectedItem = FirewallProtocol.ProtocolNumber.ToString();
+                }
             }
         }
 
         public ushort PortNumber
         {
-            get { return (ushort) nud_port.Value; }
-            set { nud_port.Value = value; }
+            get => (ushort) nud_port.Value;
+            set => nud_port.Value = value;
         }
 
         private void FormSubmit(object sender, EventArgs e)

WindowsFirewallHelper.Sample/MainForm.cs

@@ -37,6 +37,7 @@ private void AddPortRule(object sender, EventArgs e)
             try
             {
                 var portDialog = new EditPortForm();
+
                 if (portDialog.ShowDialog() == DialogResult.OK)
                 {
                     var rule = FirewallManager.Instance.CreatePortRule(
@@ -58,6 +59,7 @@ private void DeleteRule(object sender, EventArgs e)
             try
             {
                 var rule = treeView.SelectedNode.Tag as IRule;
+
                 if (rule != null)
                 {
                     FirewallManager.Instance.Rules.Remove(rule);
@@ -80,7 +82,9 @@ private void FormLoad(object sender, EventArgs e)
         private void ItemClicked(object sender, EventArgs e)
         {
             if (treeView.SelectedNode != null)
+            {
                 NodeDiscovery(treeView.SelectedNode);
+            }
         }
 
         private void ItemSelected(object sender, TreeViewEventArgs e)
@@ -97,21 +101,36 @@ private void ItemSelected(object sender, TreeViewEventArgs e)
         private void NodeDiscovery(TreeNode node)
         {
             var o = node.Tag;
+
             if (o == null)
+            {
                 return;
+            }
+
             node.Nodes.Clear();
+
             if (o.GetType().GetInterfaces().Contains(typeof(IEnumerable)))
+            {
                 foreach (var item in (IEnumerable) o)
+                {
                     node.Nodes.Add(new TreeNode(item.ToString()) {Tag = item});
+                }
+            }
             else if (!o.GetType().IsValueType)
+            {
                 foreach (var propertyInfo in o.GetType().GetProperties())
+                {
                     if (propertyInfo.PropertyType.GetInterfaces().Contains(typeof(IEnumerable)) &&
-                        (propertyInfo.PropertyType != typeof(string)))
+                        propertyInfo.PropertyType != typeof(string))
+                    {
                         if (!propertyInfo.GetGetMethod().IsStatic)
                         {
                             var value = propertyInfo.GetValue(o, null);
                             node.Nodes.Add(new TreeNode("[" + propertyInfo.Name + "] ") {Tag = value});
                         }
+                    }
+                }
+            }
         }
 
         private void RefreshTreeView()

WindowsFirewallHelper/FirewallAPIv1/FirewallProfile.cs

@@ -31,7 +31,10 @@ public bool BlockAllInboundTraffic
         /// <summary>
         ///     Gets the global default behavior regarding inbound traffic
         /// </summary>
-        /// <exception cref="T:WindowsFirewallHelper.FirewallAPIv1.FirewallAPIv1NotSupportedException">Setting a value for this property is not supported</exception>
+        /// <exception cref="T:WindowsFirewallHelper.FirewallAPIv1.FirewallAPIv1NotSupportedException">
+        ///     Setting a value for this
+        ///     property is not supported
+        /// </exception>
         public FirewallAction DefaultInboundAction
         {
             get => FirewallAction.Block;
@@ -42,7 +45,10 @@ public FirewallAction DefaultInboundAction
         /// <summary>
         ///     Gets the global default behavior regarding outbound traffic
         /// </summary>
-        /// <exception cref="T:WindowsFirewallHelper.FirewallAPIv1.FirewallAPIv1NotSupportedException">Setting a value for this property is not supported</exception>
+        /// <exception cref="T:WindowsFirewallHelper.FirewallAPIv1.FirewallAPIv1NotSupportedException">
+        ///     Setting a value for this
+        ///     property is not supported
+        /// </exception>
         public FirewallAction DefaultOutboundAction
         {
             get => FirewallAction.Allow;

WindowsFirewallHelper/FirewallAPIv2/Rules/StandardRuleWin7.cs

@@ -93,7 +93,8 @@ public EdgeTraversalAction EdgeTraversalOptions
             {
                 if (!Enum.IsDefined(typeof(EdgeTraversalAction), UnderlyingObjectV2.EdgeTraversalOptions))
                 {
-                    throw new NotSupportedException();;
+                    throw new NotSupportedException();
+                    ;
                 }
 
                 return (EdgeTraversalAction) UnderlyingObjectV2.EdgeTraversalOptions;

WindowsFirewallHelper/Helpers/EnumerableHelper.cs

@@ -11,15 +11,16 @@ public static IEnumerable<T> ToEnumerable<T>(this IEnumVARIANT enumVariant)
         {
             enumVariant.Reset();
             int bufferLength;
+
             do
             {
                 var buffer = new object[1];
-                var bufferLengthPointer = Marshal.AllocCoTaskMem(Marshal.SizeOf(typeof(Int32)));
+                var bufferLengthPointer = Marshal.AllocCoTaskMem(Marshal.SizeOf(typeof(int)));
                 enumVariant.Next(buffer.Length, buffer, bufferLengthPointer);
                 bufferLength = Marshal.ReadInt32(bufferLengthPointer);
                 Marshal.FreeCoTaskMem(bufferLengthPointer);
 
-                for (int i = 0; i < Math.Min(bufferLength, buffer.Length); i++)
+                for (var i = 0; i < Math.Min(bufferLength, buffer.Length); i++)
                 {
                     yield return (T) buffer[i];
                 }
@@ -31,16 +32,15 @@ public static IEnumerable<T> ToEnumerable<T>(this IEnumVARIANT enumVariant, int
             enumVariant.Reset();
 
             var buffer = new object[count];
-            var bufferLengthPointer = Marshal.AllocCoTaskMem(Marshal.SizeOf(typeof(Int32)));
+            var bufferLengthPointer = Marshal.AllocCoTaskMem(Marshal.SizeOf(typeof(int)));
             enumVariant.Next(buffer.Length, buffer, bufferLengthPointer);
             var bufferLength = Marshal.ReadInt32(bufferLengthPointer);
             Marshal.FreeCoTaskMem(bufferLengthPointer);
 
-            for (int i = 0; i < Math.Min(bufferLength, count); i++)
+            for (var i = 0; i < Math.Min(bufferLength, count); i++)
             {
-                yield return (T)buffer[i];
+                yield return (T) buffer[i];
             }
         }
-
     }
-}
+}