Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Add missing Elasticsearch configuration #749

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

asfalots
Copy link

What type of PR is this?

/kind feature
/kind chart-release

Any specific area of the project related to this PR?
/area falcosidekick-chart

What this PR does / why we need it:

This PR adds support for additional Elasticsearch settings in the Falco Sidekick Helm chart. Specifically, it introduces the ability to configure the pipeline, enablecompression, and maxconcurrentrequests.

Which issue(s) this PR fixes:
Fixes #748

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added dco-signoff: yes kind/feature New feature or request kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels Sep 26, 2024
@poiana
Copy link
Contributor

poiana commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asfalots
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 26, 2024

Welcome @asfalots! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from bencer and Issif September 26, 2024 12:58
@poiana poiana added the size/S label Sep 26, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature is not available in a tagged version, we can't merge this PR before it. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falcosidekick-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Elasticsearch Pipeline Configuration via Helm Values in Falco Sidekick
3 participants