Fix right click drag, when mouse up happens after holding cursor still #419
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundry, by default, allows you to pan the map with a right click drag. Sequencer also allows this when using Crosshairs. But sometimes right click dragging with a sequence will cancel it, and sometimes it pans and doesn't cancel (as expected).
The reason it sometimes cancels, is if the user stops moving the cursor beforehand, then panning gets turned off. So when the user releases the right mouse button, since
this.#isPanningis now false which makes releasing the button cancel the crosshairs instead of ending the panning.This change makes it so that once a pan is started, it essentially is always a pan, and can't be "reverted" back to a non-panning-click like what happens now.
note: I also tried this with
this.#isDragjust above but I didn't see any difference in behavior one way or the other so I opted not to change it.