[BUG] typing_extensions.Annotated cannot be used with from __future__ import annotations in py38
#802
-
First Check
Commit to Help
Example Codefrom __future__ import annotations
import typer
from typing_extensions import Annotated
def main(force: Annotated[bool, typer.Option("--force")] = False):
if force:
print("Forcing operation")
else:
print("Not forcing")
if __name__ == "__main__":
typer.run(main)DescriptionThis issue only happens with Python ≤ 3.8 because as of py39, The above is taken from the official tutorial and adding Operating SystemWindows Operating System DetailsNo response Typer Version0.12.3 Python Version3.8 Additional Contextvenv packages: |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 10 replies
-
|
I've noticed the same thing. To add to your report: I've tested with python versions |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for more information. I found that |
Beta Was this translation helpful? Give feedback.
-
|
In addition to that, digging into e.g.: Then, because of that, typer fails to "split annotations from typer annotations" here: https://github.com/tiangolo/typer/blob/d1a177c95c77e3fa294399e2708300750e6cfad2/typer/utils.py#L99-L100 |
Beta Was this translation helpful? Give feedback.
-
|
In fact it seems this has already been analized: #598 (comment) On that comment the "How could this be fixed?" section is pretty clear. The solution for python3.8 and python3.9 suggested there is correct IMO. The thing is the PR that solved this issue fixed it only for >= 3.10 (#721) I don't know why on my tests 3.9 succeeds, though. I need to re-check that. |
Beta Was this translation helpful? Give feedback.
-
|
I proposed a fix here: #814 |
Beta Was this translation helpful? Give feedback.
-
|
Great investigation @ivantodorovich 👍 Fwiw, I can monkey patch it before that PR gets merged. import typer.utils
from typing_extensions import Annotated, get_type_hints
setattr(typer.utils, "get_type_hints", get_type_hints) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you! This was indeed solved in #814 and will be available in Typer |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately I found that even with this patch, the following env combination still won't work well.
Reproducerfrom __future__ import annotations
from typing import Optional
from typing_extensions import Annotated
import typer
def patch_typer() -> None:
import typer.utils
from typing_extensions import get_type_hints
setattr(typer.utils, "get_type_hints", get_type_hints)
patch_typer()
def main(
accept: Annotated[
Optional[bool],
typer.Option("--accept/--reject", help="Accept or reject the thing"),
] = True,
) -> None:
if accept:
print("Accepting!")
else:
print("Rejecting!")
if __name__ == "__main__":
typer.run(main)run it with $ python test.py --helpand I get this It still suffers the same issue: #721
|
Beta Was this translation helpful? Give feedback.
-
|
A short example to also demonstrate the differing behavior from __future__ import annotations
import typer
from typing_extensions import Annotated
app = typer.Typer(rich_markup_mode="rich")
@app.command()
def foo(
entry: Annotated[str, typer.Option("-f", "--foo")],
) -> None:
print('foo')
app()On python 3.8.10 with typer 0.15.2: if I comment out the future annotations import, the correct behavior is recovered |
Beta Was this translation helpful? Give feedback.
-
|
@ivantodorovich - this is still hitting users. @tiangolo -- should we file a bug report here? The same code shouldn't have different behaviors in different python versions. |
Beta Was this translation helpful? Give feedback.
-
|
@kratsg: could you please open a new discussion thread, link this one, provide a minimal reproducible example and all details of your system configuration? That will help us better understand what exactly is going on. |
Beta Was this translation helpful? Give feedback.
-
|
Do note however that Python 3.8 is not supported anymore. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, python 3.8 and python 3.9 are deprecated, but there are still users on RedHat-based systems with the 10-year support that they get hit by. |
Beta Was this translation helpful? Give feedback.
I proposed a fix here: #814
It was rather simple to fix in the end ^^