Skip to content

Conversation

@svlandeg
Copy link
Member

Follow-up of #1429, I should have also edited the printed logs on the markdown page.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

@svlandeg svlandeg marked this pull request as draft November 26, 2025 15:37
Copy link
Member Author

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These emoji's don't align nicely (for me) on the docs page because they're not part of the monospace front 😭

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detecting and tweaking this! 🙌

I set it to use an explicit emoji font, to then tweak based on that, this way, it should show the same in all OSes.

Then I removed one extra space to align things with this new explicit emoji font.

@tiangolo tiangolo marked this pull request as ready for review November 28, 2025 15:46
@tiangolo tiangolo enabled auto-merge (squash) November 28, 2025 15:46
@tiangolo tiangolo merged commit ab6b439 into fastapi:master Nov 28, 2025
25 checks passed
@svlandeg svlandeg deleted the fix/emoji_again branch November 29, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants