-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate typed-css-modules #47
Comments
👍 it would be more than welcome, let me know if you need any help |
I've implemented this over at https://github.com/place1/parcel-plugin-typed-css-modules |
That's great! I believe Parcel has of not actually writing to disk for this. @fathyb Can you confirm if that's true? |
@mohsen1 I can’t understand what you’re asking 😬 |
I mean those |
right. i chose to write them to the file system because that's what webpack typed css modules loader does. importantly, it means the TS compiler and IDEs can find the declaration files. This is very useful because it means the language server can offer automatic import hints when typing css class names in ts files. with that said, i haven't really thought about an alternative, do you have something in mind? |
I think I remember now. Parcel is not using a memory fs yet. Once Parcel supports memory fs we can "write" to that fs without actually messing up the actual fs. TS language server does support custom fs. that's how it works in browser. I guess if you avoid writing to actual disk then you need to run a custom language server for your IDE as well. Maybe it doesn't worth it. |
Would you accept a pull request to add support for typed-css-modules or you think that should be a different plugin on its own?
Related to Quramy/typed-css-modules#51
The text was updated successfully, but these errors were encountered: