Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Integer System for Hadith Numbering #53

Open
unkn4wn opened this issue Mar 14, 2023 · 1 comment
Open

Unique Integer System for Hadith Numbering #53

unkn4wn opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@unkn4wn
Copy link
Contributor

unkn4wn commented Mar 14, 2023

Asselamu Aleykum,
What's the point of "hadithnumber" if it's identical to "arabicnumber" everywhere except in "Sahih Muslim"? Perhaps making "hadithnumber" a unique integer number, like a "primary key" would make more sense. That way, every hadith can be attributed to a unique integer number.

Current situation in Sahih Bukhari (also in other books):

		{
			"hadithnumber": 402,
			"arabicnumber": 402,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 53
			}
		},
		{
			"hadithnumber": 402.2,
			"arabicnumber": 402.2,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 54
			}
		},
		{
			"hadithnumber": 403,
			"arabicnumber": 403,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 55
			}
		},

My suggestion in Sahih Bukhari (also in other books):

		{
			"hadithnumber": 402,
			"arabicnumber": 402,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 53
			}
		},
		{
			"hadithnumber": 403,
			"arabicnumber": 402.2,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 54
			}
		},
		{
			"hadithnumber": 404,
			"arabicnumber": 403,
			"text": "",
			"grades": [],
			"reference": {
				"book": 8,
				"hadith": 55
			}
		},
@fawazahmed0
Copy link
Owner

This wouldn't be possible now, as this may break code who have already implemented this api. but can only be considered when a new version of API is being developed.

@fawazahmed0 fawazahmed0 added the enhancement New feature or request label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants