fix: routes/announcements: check duplicate name when creating (#73)

Author: minhhuylqd

src/v2/routes/announcements/index.ts

@@ -4,6 +4,7 @@ import { assertWithSchema, JSONSchemaType } from '../../utils/validation';
 import { ERROR_CODE, GeneralError } from '../../utils/common-errors';
 import { mustBeAdmin } from '../../utils/role-verification';
 import { getTotalAnnouncements } from './utils';
+import dbw from '../../utils/database-gateway-wrapper';
 
 // #region GET /api/v2/announcements
 
@@ -75,6 +76,13 @@ const createAnnouncementParamsSchema: JSONSchemaType<CreateAnnouncementParams> =
 async function createAnnouncement(req: Request, res: Response, next: NextFunction) {
   try {
     const { name, title, description } = assertWithSchema(req.body, createAnnouncementParamsSchema);
+    if ((await dbw.announcements.getAnnouncementOrUndefined(name)) !== undefined) {
+      throw new GeneralError({
+        error: ERROR_CODE.ANNOUNCEMENT_EXISTED,
+        error_msg: 'Announcement name already existed',
+        data: { name },
+      });
+    }
     const { error, error_msg, data } = await db.announcements.createAnnouncements({
       name: name,
       title: title,

src/v2/utils/common-errors/index.ts

@@ -4,6 +4,7 @@ export const ERROR_CODE = {
   DATABASE_GATEWAY_ERROR: 500125,
   ROLE_MUST_BE_ADMIN: 500256,
   ROUTE_NOT_FOUND: 500349,
+  ANNOUNCEMENT_NOT_FOUND: 500500,
   USER_NOT_FOUND: 500425,
   CONTEST_NOT_FOUND: 500555,
   CONTEST_CANNOT_ENTER: 500595,
@@ -16,6 +17,7 @@ export const ERROR_CODE = {
   WRONG_OLD_PASSWORD: 500835,
   USERNAME_EXISTED: 500850,
   EMAIL_EXISTED: 500900,
+  ANNOUNCEMENT_EXISTED: 501000,
   UNAUTHORIZED: 501401,
   OTP_INCORRECT: 501509,
   JWT_INVALID: 502001,

src/v2/utils/database-gateway-wrapper/components/announcement.ts

@@ -0,0 +1,19 @@
+import db from '../../database-gateway';
+import { ERROR_CODE, GeneralError } from '../../common-errors';
+import { GetAnnouncementsData } from '../../database-gateway/announcements';
+
+export async function getAnnouncementOrUndefined(announcement_name: string) {
+  const { error, error_msg, data } = await db.announcements.getAnnouncements({
+    offset: 0,
+    limit: 1,
+    announcement_name: announcement_name,
+  });
+  if (error || !data) {
+    throw new GeneralError({
+      error: ERROR_CODE.DATABASE_GATEWAY_ERROR,
+      error_msg: 'Received non-zero code from Database Gateway when getting contests',
+      data: { response: { error, error_msg, data } },
+    });
+  }
+  return data.items[0] || undefined;
+}

src/v2/utils/database-gateway-wrapper/index.ts

@@ -1,11 +1,13 @@
 import * as contests from './components/contests';
 import * as participations from './components/participations';
 import * as users from './components/users';
+import * as announcements from './components/announcement';
 
 const dbw = {
   contests,
   participations,
   users,
+  announcements,
 };
 
 export default dbw;