You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently FeastClient provides Serving access only
Describe the solution you'd like
Implement an abstract class that will handle all channel and stub common functionalities:
publicabstractclassStubManager<SextendsAbstractBlockingStub<S>> implementsAutoCloseable{
privatefinalManagedChannelchannel;
protectedSstub;
protectedabstractSgetStub(Channelchannel);
/* Include common functionalities to managing channel and stub */
}
create FeastCoreClient with new core functionalities
DeprecateFeastClient and suggest to use FeastServingClient instead
Describe alternatives you've considered
Adding to FeastClient a CoreServiceBlockingStub and a channel and just add on the core functionalities
Refactoring FeastClient to be an abstract class that has a list of all core and serving functionalities to be implemented in child FeastServingClient and FeastCoreClient classes
The text was updated successfully, but these errors were encountered:
mdeutch
changed the title
Adding Core service functionalities to SDK
[Discuss] Adding Core service functionalities to SDK
Aug 11, 2021
Is your feature request related to a problem? Please describe.
Currently FeastClient provides Serving access only
Describe the solution you'd like
FeastCoreClient
with new core functionalitiesFeastServingClient
with serving functionalities taken from FeastClientFeastClient
and suggest to use FeastServingClient insteadDescribe alternatives you've considered
FeastClient
aCoreServiceBlockingStub
and a channel and just add on the core functionalitiesFeastClient
to be an abstract class that has a list of all core and serving functionalities to be implemented in childFeastServingClient
andFeastCoreClient
classesThe text was updated successfully, but these errors were encountered: