Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Adding Core service functionalities to SDK #36

Closed
mdeutch opened this issue Aug 11, 2021 · 1 comment
Closed

[Discuss] Adding Core service functionalities to SDK #36

mdeutch opened this issue Aug 11, 2021 · 1 comment

Comments

@mdeutch
Copy link

mdeutch commented Aug 11, 2021

Is your feature request related to a problem? Please describe.
Currently FeastClient provides Serving access only

Describe the solution you'd like

  • Implement an abstract class that will handle all channel and stub common functionalities:
    public abstract class StubManager<S extends AbstractBlockingStub<S>> implements AutoCloseable{
        private final ManagedChannel channel;
        protected S stub;
    
        protected abstract S getStub(Channel channel); 
        
        /*
                Include common functionalities to managing channel and stub
         */
        
    }
  • create FeastCoreClient with new core functionalities
    public class FeastCoreClient extends StubManager<CoreServiceBlockingStub> {
      ...
    }
    • create FeastServingClient with serving functionalities taken from FeastClient
    public class FeastServingClient extends StubManager<ServingServiceBlockingStub> {
      ...
    }
  • Deprecate FeastClient and suggest to use FeastServingClient instead

Describe alternatives you've considered

  1. Adding to FeastClient a CoreServiceBlockingStub and a channel and just add on the core functionalities
  2. Refactoring FeastClient to be an abstract class that has a list of all core and serving functionalities to be implemented in child FeastServingClient and FeastCoreClient classes
@mdeutch mdeutch changed the title Adding Core service functionalities to SDK [Discuss] Adding Core service functionalities to SDK Aug 11, 2021
@mdeutch
Copy link
Author

mdeutch commented Aug 11, 2021

Important to mention that I am with Salesforce, my team has opened this issue as well.

@mdeutch mdeutch closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant