From 68717a93f2588c7ec4767b003ed61d6dc4947705 Mon Sep 17 00:00:00 2001 From: Josh Tynjala Date: Wed, 31 Jul 2024 14:06:09 -0700 Subject: [PATCH] BaseEffectContext: ignore MAX_POSITION if the tween is actively playing (closes #1827) --- source/feathers/motion/effectClasses/BaseEffectContext.as | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source/feathers/motion/effectClasses/BaseEffectContext.as b/source/feathers/motion/effectClasses/BaseEffectContext.as index f511b0583..3a04aa541 100644 --- a/source/feathers/motion/effectClasses/BaseEffectContext.as +++ b/source/feathers/motion/effectClasses/BaseEffectContext.as @@ -198,7 +198,10 @@ package feathers.motion.effectClasses */ public function set position(value:Number):void { - if(value > MAX_POSITION) + // there are some quirks with Starling tweens where we want to avoid + // going all of the way to the end, unless the tween is currently + // playing + if(!this._playing && value > MAX_POSITION) { value = MAX_POSITION; }