Skip to content

Commit

Permalink
List, GroupedList: fix for issue setting properties on item renderers…
Browse files Browse the repository at this point in the history
… and the changed properties miss the typical renderer
  • Loading branch information
joshtynjala committed Apr 2, 2014
1 parent c5ef3ee commit 6c6a2d3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1235,18 +1235,10 @@ package feathers.controls.supportClasses
{
for each(var renderer:IGroupedListItemRenderer in this._activeItemRenderers)
{
if(renderer == this._typicalItemRenderer)
{
continue;
}
this.refreshOneItemRendererStyles(renderer);
}
for each(renderer in this._activeFirstItemRenderers)
{
if(renderer == this._typicalItemRenderer)
{
continue;
}
this.refreshOneItemRendererStyles(renderer);
}
for each(renderer in this._activeLastItemRenderers)
Expand All @@ -1255,10 +1247,6 @@ package feathers.controls.supportClasses
}
for each(renderer in this._activeSingleItemRenderers)
{
if(renderer == this._typicalItemRenderer)
{
continue;
}
this.refreshOneItemRendererStyles(renderer);
}
}
Expand Down Expand Up @@ -1591,8 +1579,7 @@ package feathers.controls.supportClasses
}
//we need to set the typical item renderer's properties here
//because they may be needed for proper measurement in a virtual
//layout. we'll skip this item renderer later when the
//properties on other item renderers are set.
//layout.
this.refreshOneItemRendererStyles(this._typicalItemRenderer);
}

Expand Down
7 changes: 1 addition & 6 deletions source/feathers/controls/supportClasses/ListDataViewPort.as
Original file line number Diff line number Diff line change
Expand Up @@ -723,10 +723,6 @@ package feathers.controls.supportClasses
{
for each(var renderer:IListItemRenderer in this._activeRenderers)
{
if(renderer == this._typicalItemRenderer)
{
continue;
}
this.refreshOneItemRendererStyles(renderer);
}
}
Expand Down Expand Up @@ -829,8 +825,7 @@ package feathers.controls.supportClasses
}
//we need to set the typical item renderer's properties here
//because they may be needed for proper measurement in a virtual
//layout. we'll skip this item renderer later when the
//properties on other item renderers are set.
//layout.
this.refreshOneItemRendererStyles(this._typicalItemRenderer);
}

Expand Down

0 comments on commit 6c6a2d3

Please sign in to comment.