Skip to content

Commit 6c6a2d3

Browse files
committed
List, GroupedList: fix for issue setting properties on item renderers and the changed properties miss the typical renderer
1 parent c5ef3ee commit 6c6a2d3

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

source/feathers/controls/supportClasses/GroupedListDataViewPort.as

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1235,18 +1235,10 @@ package feathers.controls.supportClasses
12351235
{
12361236
for each(var renderer:IGroupedListItemRenderer in this._activeItemRenderers)
12371237
{
1238-
if(renderer == this._typicalItemRenderer)
1239-
{
1240-
continue;
1241-
}
12421238
this.refreshOneItemRendererStyles(renderer);
12431239
}
12441240
for each(renderer in this._activeFirstItemRenderers)
12451241
{
1246-
if(renderer == this._typicalItemRenderer)
1247-
{
1248-
continue;
1249-
}
12501242
this.refreshOneItemRendererStyles(renderer);
12511243
}
12521244
for each(renderer in this._activeLastItemRenderers)
@@ -1255,10 +1247,6 @@ package feathers.controls.supportClasses
12551247
}
12561248
for each(renderer in this._activeSingleItemRenderers)
12571249
{
1258-
if(renderer == this._typicalItemRenderer)
1259-
{
1260-
continue;
1261-
}
12621250
this.refreshOneItemRendererStyles(renderer);
12631251
}
12641252
}
@@ -1591,8 +1579,7 @@ package feathers.controls.supportClasses
15911579
}
15921580
//we need to set the typical item renderer's properties here
15931581
//because they may be needed for proper measurement in a virtual
1594-
//layout. we'll skip this item renderer later when the
1595-
//properties on other item renderers are set.
1582+
//layout.
15961583
this.refreshOneItemRendererStyles(this._typicalItemRenderer);
15971584
}
15981585

source/feathers/controls/supportClasses/ListDataViewPort.as

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -723,10 +723,6 @@ package feathers.controls.supportClasses
723723
{
724724
for each(var renderer:IListItemRenderer in this._activeRenderers)
725725
{
726-
if(renderer == this._typicalItemRenderer)
727-
{
728-
continue;
729-
}
730726
this.refreshOneItemRendererStyles(renderer);
731727
}
732728
}
@@ -829,8 +825,7 @@ package feathers.controls.supportClasses
829825
}
830826
//we need to set the typical item renderer's properties here
831827
//because they may be needed for proper measurement in a virtual
832-
//layout. we'll skip this item renderer later when the
833-
//properties on other item renderers are set.
828+
//layout.
834829
this.refreshOneItemRendererStyles(this._typicalItemRenderer);
835830
}
836831

0 commit comments

Comments
 (0)