From 6c6a2d341559fefd2f616c158f9f6d4146fe342e Mon Sep 17 00:00:00 2001 From: Josh Tynjala Date: Wed, 2 Apr 2014 11:29:55 -0700 Subject: [PATCH] List, GroupedList: fix for issue setting properties on item renderers and the changed properties miss the typical renderer --- .../supportClasses/GroupedListDataViewPort.as | 15 +-------------- .../controls/supportClasses/ListDataViewPort.as | 7 +------ 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/source/feathers/controls/supportClasses/GroupedListDataViewPort.as b/source/feathers/controls/supportClasses/GroupedListDataViewPort.as index 7cec9dd36b..020af9dd0e 100644 --- a/source/feathers/controls/supportClasses/GroupedListDataViewPort.as +++ b/source/feathers/controls/supportClasses/GroupedListDataViewPort.as @@ -1235,18 +1235,10 @@ package feathers.controls.supportClasses { for each(var renderer:IGroupedListItemRenderer in this._activeItemRenderers) { - if(renderer == this._typicalItemRenderer) - { - continue; - } this.refreshOneItemRendererStyles(renderer); } for each(renderer in this._activeFirstItemRenderers) { - if(renderer == this._typicalItemRenderer) - { - continue; - } this.refreshOneItemRendererStyles(renderer); } for each(renderer in this._activeLastItemRenderers) @@ -1255,10 +1247,6 @@ package feathers.controls.supportClasses } for each(renderer in this._activeSingleItemRenderers) { - if(renderer == this._typicalItemRenderer) - { - continue; - } this.refreshOneItemRendererStyles(renderer); } } @@ -1591,8 +1579,7 @@ package feathers.controls.supportClasses } //we need to set the typical item renderer's properties here //because they may be needed for proper measurement in a virtual - //layout. we'll skip this item renderer later when the - //properties on other item renderers are set. + //layout. this.refreshOneItemRendererStyles(this._typicalItemRenderer); } diff --git a/source/feathers/controls/supportClasses/ListDataViewPort.as b/source/feathers/controls/supportClasses/ListDataViewPort.as index 29c8f42f38..a2291f8738 100644 --- a/source/feathers/controls/supportClasses/ListDataViewPort.as +++ b/source/feathers/controls/supportClasses/ListDataViewPort.as @@ -723,10 +723,6 @@ package feathers.controls.supportClasses { for each(var renderer:IListItemRenderer in this._activeRenderers) { - if(renderer == this._typicalItemRenderer) - { - continue; - } this.refreshOneItemRendererStyles(renderer); } } @@ -829,8 +825,7 @@ package feathers.controls.supportClasses } //we need to set the typical item renderer's properties here //because they may be needed for proper measurement in a virtual - //layout. we'll skip this item renderer later when the - //properties on other item renderers are set. + //layout. this.refreshOneItemRendererStyles(this._typicalItemRenderer); }