test case fixes and remove unused code

Author: Tan108

src/main/kotlin/com/featurevisor/sdk/FeaturevisorError.kt

@@ -19,7 +19,4 @@ sealed class FeaturevisorError(message: String) : Throwable(message = message) {
     class InvalidUrl(val url: String?) : FeaturevisorError("Invalid URL")
 
     object MissingDatafileUrlWhileRefreshing : FeaturevisorError("Missing datafile url need to refresh")
-
-    /// Fetching was cancelled
-    object FetchingDataFileCancelled : FeaturevisorError("Fetching data file cancelled")
 }

src/main/kotlin/com/featurevisor/sdk/Instance+Fetch.kt

@@ -8,6 +8,9 @@ import kotlinx.serialization.json.Json
 import okhttp3.HttpUrl.Companion.toHttpUrl
 import java.lang.IllegalArgumentException
 
+const val BODY_BYTE_COUNT = 1000000L
+val client = OkHttpClient()
+
 // MARK: - Fetch datafile content
 @Throws(IOException::class)
 internal fun FeaturevisorInstance.fetchDatafileContent(
@@ -40,10 +43,6 @@ private fun fetchDatafileContentFromUrl(
     }
 }
 
-const val BODY_BYTE_COUNT = 1000000L
-val client = OkHttpClient()
-
-
 private inline fun fetch(
     request: Request,
     crossinline completion: (Result<DatafileContent>) -> Unit,

src/main/kotlin/com/featurevisor/sdk/InstanceOptions.kt

@@ -23,8 +23,6 @@ data class InstanceOptions(
     val onError: Listener? = null,
     val refreshInterval: Long? = null, // seconds
     val stickyFeatures: StickyFeatures? = null,
-    val retryInterval: Long = 300L,
-    val retryCount: Int = 1,
 ) {
     companion object {
         private const val defaultBucketKeySeparator = "."

src/main/kotlin/com/featurevisor/types/Types.kt

@@ -339,12 +339,6 @@ data class DatafileContent(
     val features: List<Feature>,
 )
 
-@Serializable
-data class DatafileFetchResult(
-    val datafileContent: DatafileContent,
-    val responseBodyString: String
-)
-
 @Serializable
 data class OverrideFeature(
     val enabled: Boolean,

src/test/kotlin/com/featurevisor/sdk/InstanceTest.kt

@@ -8,6 +8,7 @@ import io.kotest.matchers.shouldBe
 import io.mockk.coEvery
 import io.mockk.mockk
 import io.mockk.unmockkAll
+import io.mockk.verify
 import kotlinx.coroutines.*
 import kotlinx.coroutines.test.TestCoroutineDispatcher
 import kotlinx.coroutines.test.TestCoroutineScope
@@ -73,21 +74,23 @@ class InstanceTest {
 
     @Test
     fun `instance fetches data using handleDatafileFetch`() {
-        coEvery { mockDatafileFetchHandler(datafileUrl) } returns Result.success(datafileContent)
-        instanceOptions = instanceOptions.copy(
-            datafileUrl = datafileUrl,
-            datafile = null,
-            handleDatafileFetch = mockDatafileFetchHandler,
-        )
-
-        FeaturevisorInstance.createInstance(
-            options = instanceOptions
-        )
-// TODO: FixMe
-//        verify(exactly = 1) {
-//            mockDatafileFetchHandler(datafileUrl)
-//        }
-        systemUnderTest.statuses.ready shouldBe true
+        testScope.launch {
+            coEvery { mockDatafileFetchHandler(datafileUrl) } returns Result.success(datafileContent)
+
+            val sdk = FeaturevisorInstance.createInstance(
+                options = instanceOptions.copy(
+                    datafileUrl = datafileUrl,
+                    datafile = null,
+                    handleDatafileFetch = mockDatafileFetchHandler,
+                )
+            )
+
+            sdk.statuses.ready shouldBe true
+
+            verify(exactly = 1) {
+                mockDatafileFetchHandler(datafileUrl)
+            }
+        }
     }
 
     @Test