From b40cd4f640a3bb9c787b6e32e8232d68679d9042 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Fri, 24 Nov 2023 00:13:52 -0600 Subject: [PATCH] chore(flutter_github_search): update styles for material 3 compat --- .../ios/Runner.xcodeproj/project.pbxproj | 2 +- .../xcshareddata/xcschemes/Runner.xcscheme | 2 +- .../flutter_github_search/lib/search_form.dart | 9 ++------- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/project.pbxproj b/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/project.pbxproj index ea46491e3fd..2421cfa5cf8 100644 --- a/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/project.pbxproj +++ b/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/project.pbxproj @@ -215,7 +215,7 @@ 97C146E61CF9000F007C117D /* Project object */ = { isa = PBXProject; attributes = { - LastUpgradeCheck = 1300; + LastUpgradeCheck = 1430; ORGANIZATIONNAME = ""; TargetAttributes = { 331C8080294A63A400263BE5 = { diff --git a/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme index e42adcb34c2..87131a09bea 100644 --- a/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme +++ b/examples/github_search/flutter_github_search/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme @@ -1,6 +1,6 @@ const Text('Please enter a term to begin'), - SearchStateLoading() => const CircularProgressIndicator(), + SearchStateLoading() => const CircularProgressIndicator.adaptive(), SearchStateError() => Text(state.error), SearchStateSuccess() => state.items.isEmpty ? const Text('No Results') @@ -112,12 +112,7 @@ class _SearchResultItem extends StatelessWidget { child: Image.network(item.owner.avatarUrl), ), title: Text(item.fullName), - onTap: () async { - final uri = Uri.parse(item.htmlUrl); - if (await canLaunchUrl(uri)) { - await launchUrl(uri); - } - }, + onTap: () => launchUrl(Uri.parse(item.htmlUrl)), ); } }