Skip to content

Commit a04f84f

Browse files
greenkeeper[bot]gr2m
greenkeeper[bot]
and
gr2m
authored
build(deps): xo updated (semantic-release#263)
Co-authored-by: Gregor Martynus <[email protected]>
1 parent 26f4892 commit a04f84f

24 files changed

+233
-232
lines changed

‎index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ async function verifyConditions(pluginConfig, context) {
1414
// If the GitHub publish plugin is used and has `assets`, `successComment`, `failComment`, `failTitle`, `labels` or `assignees` configured, validate it now in order to prevent any release if the configuration is wrong
1515
if (options.publish) {
1616
const publishPlugin =
17-
castArray(options.publish).find(config => config.path && config.path === '@semantic-release/github') || {};
17+
castArray(options.publish).find((config) => config.path && config.path === '@semantic-release/github') || {};
1818

1919
pluginConfig.assets = defaultTo(pluginConfig.assets, publishPlugin.assets);
2020
pluginConfig.successComment = defaultTo(pluginConfig.successComment, publishPlugin.successComment);

‎lib/definitions/errors.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ const {isString} = require('lodash');
33
const pkg = require('../../package.json');
44

55
const [homepage] = pkg.homepage.split('#');
6-
const stringify = object =>
6+
const stringify = (object) =>
77
isString(object) ? object : inspect(object, {breakLength: Infinity, depth: 2, maxArrayLength: 5});
8-
const linkify = file => `${homepage}/blob/master/${file}`;
8+
const linkify = (file) => `${homepage}/blob/master/${file}`;
99

1010
module.exports = {
1111
EINVALIDASSETS: ({assets}) => ({

‎lib/find-sr-issues.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ module.exports = async (github, title, owner, repo) => {
77
q: `in:title+repo:${owner}/${repo}+type:issue+state:open+${title}`,
88
});
99

10-
return issues.filter(issue => issue.body && issue.body.includes(ISSUE_ID));
10+
return issues.filter((issue) => issue.body && issue.body.includes(ISSUE_ID));
1111
};

‎lib/get-client.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const {RETRY_CONF, RATE_LIMITS, GLOBAL_RATE_LIMIT} = require('./definitions/rate
1111
/**
1212
* Http error status for which to not retry.
1313
*/
14-
const SKIP_RETRY_CODES = [400, 401, 403];
14+
const SKIP_RETRY_CODES = new Set([400, 401, 403]);
1515

1616
/**
1717
* Create or retrieve the throttler function for a given rate limit group.
@@ -50,7 +50,7 @@ module.exports = ({githubToken, githubUrl, githubApiPathPrefix, proxy}) => {
5050
try {
5151
return await getThrottler(limitKey, globalThrottler).wrap(request)(options);
5252
} catch (error) {
53-
if (SKIP_RETRY_CODES.includes(error.status)) {
53+
if (SKIP_RETRY_CODES.has(error.status)) {
5454
throw new pRetry.AbortError(error);
5555
}
5656

‎lib/get-fail-comment.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ const GET_HELP_URL = `${HOME_URL}#get-help`;
44
const USAGE_DOC_URL = `${HOME_URL}/blob/caribou/docs/usage/README.md`;
55
const NEW_ISSUE_URL = `${HOME_URL}/issues/new`;
66

7-
const formatError = error => `### ${error.message}
7+
const formatError = (error) => `### ${error.message}
88
9-
${error.details ||
9+
${
10+
error.details ||
1011
`Unfortunately this error doesn't have any additional information.${
1112
error.pluginName
1213
? ` Feel free to kindly ask the author of the \`${error.pluginName}\` plugin to add more helpful information.`
1314
: ''
14-
}`}`;
15+
}`
16+
}`;
1517

1618
module.exports = (branch, errors) => `## :rotating_light: The automated release from the \`${
1719
branch.name

‎lib/get-success-comment.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const HOME_URL = 'https://github.com/semantic-release/semantic-release';
2-
const linkify = releaseInfo =>
2+
const linkify = (releaseInfo) =>
33
`${releaseInfo.url ? `[${releaseInfo.name}](${releaseInfo.url})` : `\`${releaseInfo.name}\``}`;
44

55
module.exports = (issue, releaseInfos, nextRelease) =>
@@ -10,7 +10,7 @@ module.exports = (issue, releaseInfos, nextRelease) =>
1010
? `\n\nThe release is available on${
1111
releaseInfos.length === 1
1212
? ` ${linkify(releaseInfos[0])}`
13-
: `:\n${releaseInfos.map(releaseInfo => `- ${linkify(releaseInfo)}`).join('\n')}`
13+
: `:\n${releaseInfos.map((releaseInfo) => `- ${linkify(releaseInfo)}`).join('\n')}`
1414
}`
1515
: ''
1616
}

‎lib/glob-assets.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module.exports = async ({cwd}, assets) =>
1010
[]
1111
.concat(
1212
...(await Promise.all(
13-
assets.map(async asset => {
13+
assets.map(async (asset) => {
1414
// Wrap single glob definition in Array
1515
let glob = castArray(isPlainObject(asset) ? asset.path : asset);
1616
// TODO Temporary workaround for https://github.com/mrmlnc/fast-glob/issues/47
@@ -40,7 +40,7 @@ module.exports = async ({cwd}, assets) =>
4040
// - `path` of the matched file
4141
// - `name` based on the actual file name (to avoid assets with duplicate `name`)
4242
// - other properties of the original asset definition
43-
return globbed.map(file => ({...asset, path: file, name: basename(file)}));
43+
return globbed.map((file) => ({...asset, path: file, name: basename(file)}));
4444
}
4545

4646
// If asset is an Object, output an Object definition with:
@@ -60,7 +60,7 @@ module.exports = async ({cwd}, assets) =>
6060
// Sort with Object first, to prioritize Object definition over Strings in dedup
6161
))
6262
)
63-
.sort(asset => (isPlainObject(asset) ? -1 : 1)),
63+
.sort((asset) => (isPlainObject(asset) ? -1 : 1)),
6464
// Compare `path` property if Object definition, value itself if String
6565
(a, b) => path.resolve(cwd, isPlainObject(a) ? a.path : a) === path.resolve(cwd, isPlainObject(b) ? b.path : b)
6666
);

‎lib/parse-github-url.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module.exports = repositoryUrl => {
1+
module.exports = (repositoryUrl) => {
22
const [match, auth, host, path] = /^(?!.+:\/\/)(?:(?<auth>.*)@)?(?<host>.*?):(?<path>.*)$/.exec(repositoryUrl) || [];
33
try {
44
const [, owner, repo] = /^\/(?<owner>[^/]+)?\/?(?<repo>.+?)(?:\.git)?$/.exec(

‎lib/publish.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module.exports = async (pluginConfig, context) => {
4848
debug('globed assets: %o', globbedAssets);
4949

5050
await Promise.all(
51-
globbedAssets.map(async asset => {
51+
globbedAssets.map(async (asset) => {
5252
const filePath = isPlainObject(asset) ? asset.path : asset;
5353
let file;
5454

‎lib/success.js

+18-15
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ module.exports = async (pluginConfig, context) => {
3939
logger.log('Skip commenting on issues and pull requests.');
4040
} else {
4141
const parser = issueParser('github', githubUrl ? {hosts: [githubUrl]} : {});
42-
const releaseInfos = releases.filter(release => Boolean(release.name));
42+
const releaseInfos = releases.filter((release) => Boolean(release.name));
4343
const shas = commits.map(({hash}) => hash);
4444

4545
const searchQueries = getSearchQueries(`repo:${owner}/${repo}+type:pr+is:merged`, shas).map(
46-
async q => (await github.search.issuesAndPullRequests({q})).data.items
46+
async (q) => (await github.search.issuesAndPullRequests({q})).data.items
4747
);
4848

4949
const prs = await pFilter(
@@ -55,24 +55,27 @@ module.exports = async (pluginConfig, context) => {
5555

5656
debug(
5757
'found pull requests: %O',
58-
prs.map(pr => pr.number)
58+
prs.map((pr) => pr.number)
5959
);
6060

6161
// Parse the release commits message and PRs body to find resolved issues/PRs via comment keyworkds
62-
const issues = [...prs.map(pr => pr.body), ...commits.map(commit => commit.message)].reduce((issues, message) => {
63-
return message
64-
? issues.concat(
65-
parser(message)
66-
.actions.close.filter(action => isNil(action.slug) || action.slug === `${owner}/${repo}`)
67-
.map(action => ({number: parseInt(action.issue, 10)}))
68-
)
69-
: issues;
70-
}, []);
62+
const issues = [...prs.map((pr) => pr.body), ...commits.map((commit) => commit.message)].reduce(
63+
(issues, message) => {
64+
return message
65+
? issues.concat(
66+
parser(message)
67+
.actions.close.filter((action) => isNil(action.slug) || action.slug === `${owner}/${repo}`)
68+
.map((action) => ({number: Number.parseInt(action.issue, 10)}))
69+
)
70+
: issues;
71+
},
72+
[]
73+
);
7174

7275
debug('found issues via comments: %O', issues);
7376

7477
await Promise.all(
75-
uniqBy([...prs, ...issues], 'number').map(async issue => {
78+
uniqBy([...prs, ...issues], 'number').map(async (issue) => {
7679
const body = successComment
7780
? template(successComment)({...context, issue})
7881
: getSuccessComment(issue, releaseInfos, nextRelease);
@@ -85,7 +88,7 @@ module.exports = async (pluginConfig, context) => {
8588
logger.log('Added comment to issue #%d: %s', issue.number, url);
8689

8790
if (releasedLabels) {
88-
const labels = releasedLabels.map(label => template(label)(context));
91+
const labels = releasedLabels.map((label) => template(label)(context));
8992
// Don’t use .issues.addLabels for GHE < 2.16 support
9093
// https://github.com/semantic-release/github/issues/138
9194
await github.request('POST /repos/:owner/:repo/issues/:number/labels', {
@@ -119,7 +122,7 @@ module.exports = async (pluginConfig, context) => {
119122
debug('found semantic-release issues: %O', srIssues);
120123

121124
await Promise.all(
122-
srIssues.map(async issue => {
125+
srIssues.map(async (issue) => {
123126
debug('close issue: %O', issue);
124127
try {
125128
const updateIssue = {owner, repo, issue_number: issue.number, state: 'closed'};

‎lib/verify.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ const resolveConfig = require('./resolve-config');
66
const getClient = require('./get-client');
77
const getError = require('./get-error');
88

9-
const isNonEmptyString = value => isString(value) && value.trim();
10-
const isStringOrStringArray = value => isNonEmptyString(value) || (isArray(value) && value.every(isNonEmptyString));
11-
const isArrayOf = validator => array => isArray(array) && array.every(value => validator(value));
12-
const canBeDisabled = validator => value => value === false || validator(value);
9+
const isNonEmptyString = (value) => isString(value) && value.trim();
10+
const isStringOrStringArray = (value) => isNonEmptyString(value) || (isArray(value) && value.every(isNonEmptyString));
11+
const isArrayOf = (validator) => (array) => isArray(array) && array.every((value) => validator(value));
12+
const canBeDisabled = (validator) => (value) => value === false || validator(value);
1313

1414
const VALIDATORS = {
15-
proxy: proxy =>
15+
proxy: (proxy) =>
1616
isNonEmptyString(proxy) || (isPlainObject(proxy) && isNonEmptyString(proxy.host) && isNumber(proxy.port)),
1717
assets: isArrayOf(
18-
asset => isStringOrStringArray(asset) || (isPlainObject(asset) && isStringOrStringArray(asset.path))
18+
(asset) => isStringOrStringArray(asset) || (isPlainObject(asset) && isStringOrStringArray(asset.path))
1919
),
2020
successComment: canBeDisabled(isNonEmptyString),
2121
failTitle: canBeDisabled(isNonEmptyString),

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"server-destroy": "^1.0.1",
4646
"sinon": "^9.0.0",
4747
"tempy": "^0.5.0",
48-
"xo": "^0.28.0"
48+
"xo": "^0.29.0"
4949
},
5050
"engines": {
5151
"node": ">=10.18"

‎test/add-channel.test.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const addChannel = proxyquire('../lib/add-channel', {
1111
'./get-client': proxyquire('../lib/get-client', {'./definitions/rate-limit': rateLimit}),
1212
});
1313

14-
test.beforeEach(t => {
14+
test.beforeEach((t) => {
1515
// Mock logger
1616
t.context.log = stub();
1717
t.context.error = stub();
@@ -23,7 +23,7 @@ test.afterEach.always(() => {
2323
nock.cleanAll();
2424
});
2525

26-
test.serial('Update a release', async t => {
26+
test.serial('Update a release', async (t) => {
2727
const owner = 'test_user';
2828
const repo = 'test_repo';
2929
const env = {GITHUB_TOKEN: 'github_token'};
@@ -56,7 +56,7 @@ test.serial('Update a release', async t => {
5656
t.true(github.isDone());
5757
});
5858

59-
test.serial('Update a maintenance release', async t => {
59+
test.serial('Update a maintenance release', async (t) => {
6060
const owner = 'test_user';
6161
const repo = 'test_repo';
6262
const env = {GITHUB_TOKEN: 'github_token'};
@@ -89,7 +89,7 @@ test.serial('Update a maintenance release', async t => {
8989
t.true(github.isDone());
9090
});
9191

92-
test.serial('Update a prerelease', async t => {
92+
test.serial('Update a prerelease', async (t) => {
9393
const owner = 'test_user';
9494
const repo = 'test_repo';
9595
const env = {GITHUB_TOKEN: 'github_token'};
@@ -122,7 +122,7 @@ test.serial('Update a prerelease', async t => {
122122
t.true(github.isDone());
123123
});
124124

125-
test.serial('Update a release with a custom github url', async t => {
125+
test.serial('Update a release with a custom github url', async (t) => {
126126
const owner = 'test_user';
127127
const repo = 'test_repo';
128128
const env = {GH_URL: 'https://othertesturl.com:443', GH_TOKEN: 'github_token', GH_PREFIX: 'prefix'};
@@ -155,7 +155,7 @@ test.serial('Update a release with a custom github url', async t => {
155155
t.true(github.isDone());
156156
});
157157

158-
test.serial('Update a release, retrying 4 times', async t => {
158+
test.serial('Update a release, retrying 4 times', async (t) => {
159159
const owner = 'test_user';
160160
const repo = 'test_repo';
161161
const env = {GITHUB_TOKEN: 'github_token'};
@@ -198,7 +198,7 @@ test.serial('Update a release, retrying 4 times', async t => {
198198
t.true(github.isDone());
199199
});
200200

201-
test.serial('Create the new release if current one is missing', async t => {
201+
test.serial('Create the new release if current one is missing', async (t) => {
202202
const owner = 'test_user';
203203
const repo = 'test_repo';
204204
const env = {GITHUB_TOKEN: 'github_token'};
@@ -233,7 +233,7 @@ test.serial('Create the new release if current one is missing', async t => {
233233
t.true(github.isDone());
234234
});
235235

236-
test.serial('Throw error if cannot read current release', async t => {
236+
test.serial('Throw error if cannot read current release', async (t) => {
237237
const owner = 'test_user';
238238
const repo = 'test_repo';
239239
const env = {GITHUB_TOKEN: 'github_token'};
@@ -260,7 +260,7 @@ test.serial('Throw error if cannot read current release', async t => {
260260
t.true(github.isDone());
261261
});
262262

263-
test.serial('Throw error if cannot create missing current release', async t => {
263+
test.serial('Throw error if cannot create missing current release', async (t) => {
264264
const owner = 'test_user';
265265
const repo = 'test_repo';
266266
const env = {GITHUB_TOKEN: 'github_token'};
@@ -295,7 +295,7 @@ test.serial('Throw error if cannot create missing current release', async t => {
295295
t.true(github.isDone());
296296
});
297297

298-
test.serial('Throw error if cannot update release', async t => {
298+
test.serial('Throw error if cannot update release', async (t) => {
299299
const owner = 'test_user';
300300
const repo = 'test_repo';
301301
const env = {GITHUB_TOKEN: 'github_token'};

‎test/fail.test.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const fail = proxyquire('../lib/fail', {
1414
'./get-client': proxyquire('../lib/get-client', {'./definitions/rate-limit': rateLimit}),
1515
});
1616

17-
test.beforeEach(t => {
17+
test.beforeEach((t) => {
1818
// Mock logger
1919
t.context.log = stub();
2020
t.context.error = stub();
@@ -26,7 +26,7 @@ test.afterEach.always(() => {
2626
nock.cleanAll();
2727
});
2828

29-
test.serial('Open a new issue with the list of errors', async t => {
29+
test.serial('Open a new issue with the list of errors', async (t) => {
3030
const owner = 'test_user';
3131
const repo = 'test_repo';
3232
const redirectedOwner = 'test_user_2';
@@ -62,7 +62,7 @@ test.serial('Open a new issue with the list of errors', async t => {
6262
t.true(github.isDone());
6363
});
6464

65-
test.serial('Open a new issue with the list of errors, retrying 4 times', async t => {
65+
test.serial('Open a new issue with the list of errors, retrying 4 times', async (t) => {
6666
const owner = 'test_user';
6767
const repo = 'test_repo';
6868
const env = {GITHUB_TOKEN: 'github_token'};
@@ -110,7 +110,7 @@ test.serial('Open a new issue with the list of errors, retrying 4 times', async
110110
t.true(github.isDone());
111111
});
112112

113-
test.serial('Open a new issue with the list of errors and custom title and comment', async t => {
113+
test.serial('Open a new issue with the list of errors and custom title and comment', async (t) => {
114114
const owner = 'test_user';
115115
const repo = 'test_repo';
116116
const env = {GITHUB_TOKEN: 'github_token'};
@@ -145,7 +145,7 @@ test.serial('Open a new issue with the list of errors and custom title and comme
145145
t.true(github.isDone());
146146
});
147147

148-
test.serial('Open a new issue with assignees and the list of errors', async t => {
148+
test.serial('Open a new issue with assignees and the list of errors', async (t) => {
149149
const owner = 'test_user';
150150
const repo = 'test_repo';
151151
const env = {GITHUB_TOKEN: 'github_token'};
@@ -180,7 +180,7 @@ test.serial('Open a new issue with assignees and the list of errors', async t =>
180180
t.true(github.isDone());
181181
});
182182

183-
test.serial('Open a new issue without labels and the list of errors', async t => {
183+
test.serial('Open a new issue without labels and the list of errors', async (t) => {
184184
const owner = 'test_user';
185185
const repo = 'test_repo';
186186
const env = {GITHUB_TOKEN: 'github_token'};
@@ -214,7 +214,7 @@ test.serial('Open a new issue without labels and the list of errors', async t =>
214214
t.true(github.isDone());
215215
});
216216

217-
test.serial('Update the first existing issue with the list of errors', async t => {
217+
test.serial('Update the first existing issue with the list of errors', async (t) => {
218218
const owner = 'test_user';
219219
const repo = 'test_repo';
220220
const env = {GITHUB_TOKEN: 'github_token'};
@@ -252,7 +252,7 @@ test.serial('Update the first existing issue with the list of errors', async t =
252252
t.true(github.isDone());
253253
});
254254

255-
test.serial('Skip if "failComment" is "false"', async t => {
255+
test.serial('Skip if "failComment" is "false"', async (t) => {
256256
const owner = 'test_user';
257257
const repo = 'test_repo';
258258
const env = {GITHUB_TOKEN: 'github_token'};
@@ -269,7 +269,7 @@ test.serial('Skip if "failComment" is "false"', async t => {
269269
t.true(t.context.log.calledWith('Skip issue creation.'));
270270
});
271271

272-
test.serial('Skip if "failTitle" is "false"', async t => {
272+
test.serial('Skip if "failTitle" is "false"', async (t) => {
273273
const owner = 'test_user';
274274
const repo = 'test_repo';
275275
const env = {GITHUB_TOKEN: 'github_token'};

0 commit comments

Comments
 (0)