lint

Author: felixdorn

src/Exceptions/TwitterException.php

@@ -2,11 +2,9 @@
 
 namespace Felix\TwitterStream\Exceptions;
 
-use Exception;
-use JsonException;
 use Psr\Http\Message\ResponseInterface;
 
-class TwitterException extends Exception
+class TwitterException extends \Exception
 {
     private const PRETTY_PRINT_FLAGS = JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
 
@@ -16,7 +14,7 @@ protected function __construct(string $message)
     }
 
     /**
-     * @throws JsonException
+     * @throws \JsonException
      */
     public static function fromResponse(ResponseInterface $response): TwitterException
     {
@@ -26,7 +24,7 @@ public static function fromResponse(ResponseInterface $response): TwitterExcepti
 
         try {
             $body = json_decode($response->getBody()->getContents(), true, 512, flags: JSON_THROW_ON_ERROR);
-        } catch (JsonException $e) {
+        } catch (\JsonException $e) {
             return TwitterException::sprintf(
                 'Twitter response was not valid JSON: %s (error while parsing: %s)',
                 $response->getBody()->getContents(),
@@ -77,7 +75,7 @@ public static function sprintf(string $message, mixed ...$args): self
 
     private static function handleTitleDetailErrors(array $body): self
     {
-        $title = $body['title'];
+        $title  = $body['title'];
         $detail = $body['detail'];
 
         // Remove the detail if it's the same as the title

src/Parser/Listener.php

@@ -113,9 +113,6 @@ public function key(string $key): void
         $this->key = $key;
     }
 
-    /**
-     * @param mixed $value
-     */
     public function value($value): void
     {
         $obj = array_pop($this->stack);

src/Parser/Parser.php

@@ -128,11 +128,11 @@ private function consumeChar(string $char): void
         // valid whitespace characters in JSON (from RFC4627 for JSON) include:
         // space, horizontal tab, line feed or new line, and carriage return.
         // thanks: http://stackoverflow.com/questions/16042274/definition-of-whitespace-in-json
-        if ((' ' === $char || "\t" === $char || "\n" === $char || "\r" === $char) &&
-            !(self::STATE_IN_STRING === $this->state ||
-                self::STATE_UNICODE === $this->state ||
-                self::STATE_START_ESCAPE === $this->state ||
-                self::STATE_IN_NUMBER === $this->state)
+        if ((' ' === $char || "\t" === $char || "\n" === $char || "\r" === $char)
+            && !(self::STATE_IN_STRING === $this->state
+                || self::STATE_UNICODE === $this->state
+                || self::STATE_START_ESCAPE === $this->state
+                || self::STATE_IN_NUMBER === $this->state)
         ) {
             // we wrap this so that we don't make a ton of unnecessary function calls
             // unless someone really, really cares about whitespace.
@@ -317,8 +317,8 @@ private function checkAndSkipUtfBom(string $c): bool
             }
         }
 
-        if (self::UTF16_BOM === $this->utfBom && 2 === $this->charNumber &&
-            $c === \chr(254)) {
+        if (self::UTF16_BOM === $this->utfBom && 2 === $this->charNumber
+            && $c === \chr(254)) {
             $this->utfBom = self::UTF32_BOM;
         }
 

src/RuleManager.php

@@ -13,7 +13,7 @@ public function all(): array
     {
         $rules = $this->connection->request('GET', 'https://api.twitter.com/2/tweets/search/stream/rules');
 
-        return array_map(fn(array $rule) => new Rule(
+        return array_map(fn (array $rule) => new Rule(
             $rule['value'],
             $rule['tag'] ?? null,
             $rule['id'] ?? null,
@@ -39,9 +39,8 @@ public function delete(Rule|string|array $ids): ?TwitterResponse
             return null;
         }
 
-
         $ids = array_filter(
-            array_map(fn($id) => $id instanceof Rule ? $id->id : $id, $ids)
+            array_map(fn ($id) => $id instanceof Rule ? $id->id : $id, $ids)
         );
 
         return $this->connection->request('POST', 'https://api.twitter.com/2/tweets/search/stream/rules', [
@@ -61,7 +60,7 @@ public function validate(string $rule): array
         return $this->save($rule, dryRun: true)->getPayload();
     }
 
-    public function save(Rule|string $value, ?string $tag = null, bool $dryRun = false): TwitterResponse
+    public function save(Rule|string $value, string $tag = null, bool $dryRun = false): TwitterResponse
     {
         if ($value instanceof Rule) {
             return $this->saveMany([$value], $dryRun);
@@ -77,7 +76,7 @@ public function saveMany(array $rules, bool $dryRun = false): TwitterResponse
 
         return $this->connection->request('POST', 'https://api.twitter.com/2/tweets/search/stream/rules' . $dryRun, [
             'body' => [
-                'add' => array_map(fn($rule) => ['value' => $rule->value, 'tag' => $rule->tag], $rules),
+                'add' => array_map(fn ($rule) => ['value' => $rule->value, 'tag' => $rule->tag], $rules),
             ],
         ]);
     }