Skip to content

Commit 2365ae0

Browse files
authored
Port deprecated Qt functionality (#70)
* porting: from QFontMetric.width to horizontalAdvance * porting: from deprecated QDesktopWidget * porting: from deprecated QListWidgetItem methods * porting: from deprecated QPlainTextEdit.setTabStopDistance * porting: from deprecated QWheelEvent.delta * porting: use Qt::endl
1 parent 6e7c6b3 commit 2365ae0

8 files changed

+15
-12
lines changed

app/configappearancewidget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ void ConfigAppearanceWidget::setItemToolTip(QTableWidgetItem *item, const QFont
117117
{
118118
const QFontMetrics metrics(font);
119119
ui.itemTable->setRowHeight(m_itemHighlighted, metrics.height() + m_itemMargin);
120-
if (metrics.width(item->text()) >= ui.itemTable->contentsRect().width() - 30)
120+
if (metrics.horizontalAdvance(item->text()) >= ui.itemTable->contentsRect().width() - 30)
121121
item->setToolTip(item->text());
122122
else
123123
item->setToolTip(QString());

app/linenumberwidget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ void LineNumberWidget::paintEvent(QPaintEvent *event)
7272
if (bottom >= event->rect().top()) {
7373
for (int i = 0; i < userBookmarks.length(); ++i) {
7474
if (userBookmarks.at(i) == lineNumber) {
75-
painter.fillRect(2, top, fm.width(QLatin1Char('B')) + 4, lineHeight,
75+
painter.fillRect(2, top, fm.horizontalAdvance(QLatin1Char('B')) + 4, lineHeight,
7676
m_highlightBrush);
7777
painter.setPen(m_highlightedTextPen);
7878
painter.drawText(4, top, width() - 4, lineHeight, Qt::AlignLeft | Qt::AlignTop,

app/mainwindow.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#endif
3737

3838
#include <QMenuBar>
39+
#include <QScreen>
3940
#include <QStatusBar>
4041
#include <QtCore/QTextCodec>
4142
#include <QtCore/QProcess>
@@ -44,7 +45,6 @@
4445
#include <QtCore/QTimer>
4546
#include <QtGui/QCloseEvent>
4647
#include <QtGui/QDesktopServices>
47-
#include <QtWidgets/QDesktopWidget>
4848
#include <QtWidgets/QDockWidget>
4949
#include <QtWidgets/QLabel>
5050
#include <QtWidgets/QMessageBox>
@@ -955,7 +955,7 @@ void MainWindow::readSettings()
955955

956956
QSettings settings;
957957
settings.beginGroup(QLatin1String("MainWindow"));
958-
const int screenWidth = QApplication::desktop()->availableGeometry().width();
958+
const int screenWidth = this->screen()->geometry().width();
959959
QSize size;
960960
if (screenWidth > 1200)
961961
size = settings.value(QLatin1String("size"), QSize(1200, 600)).toSize();

app/tikzcommandinserter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -482,8 +482,8 @@ void TikzCommandInserter::addListWidgetItems(QListWidget *listWidget,
482482
QString itemText = commandList.children.at(i).title;
483483
item->setText(itemText.remove(QLatin1Char('&')));
484484

485-
item->setBackgroundColor(titleBg);
486-
item->setTextColor(titleFg);
485+
item->setBackground(titleBg);
486+
item->setForeground(titleFg);
487487
item->setFont(titleFont);
488488

489489
addListWidgetItems(listWidget, standardPalette, commandList.children.at(i));

app/tikzeditor.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ void TikzEditor::paintSpace(QPainter &painter, qreal x, qreal y, int spaceWidth)
314314
void TikzEditor::printWhiteSpaces(QPainter &painter)
315315
{
316316
const QFontMetrics fontMetrics = QFontMetrics(document()->defaultFont());
317-
const int spaceWidth = fontMetrics.width(QLatin1Char(' '));
317+
const int spaceWidth = fontMetrics.horizontalAdvance(QLatin1Char(' '));
318318
const int fontHeight = fontMetrics.height();
319319
QTextCursor cursor = textCursor();
320320

@@ -747,7 +747,8 @@ int TikzEditor::lineNumberAreaWidth()
747747
++digits;
748748
digits = qMax(4, digits) + 1;
749749

750-
return m_showLineNumberArea ? 3 + fontMetrics().width(QLatin1Char('9')) * digits : 0;
750+
return m_showLineNumberArea ? 3 + fontMetrics().horizontalAdvance(QLatin1Char('9')) * digits
751+
: 0;
751752
}
752753

753754
void TikzEditor::updateLineNumberAreaWidth()

app/tikzeditorview.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ void TikzEditorView::setFont(const QFont &editorFont)
157157
fm.setFontPointSize(editorFont.pointSize());
158158
m_tikzEditor->setCurrentCharFormat(fm);
159159

160-
m_tikzEditor->setTabStopWidth(m_tikzEditor->fontMetrics().width(QLatin1String(" ")));
160+
m_tikzEditor->setTabStopDistance(
161+
m_tikzEditor->fontMetrics().horizontalAdvance(QLatin1String(" ")));
161162
}
162163

163164
void TikzEditorView::createActions()

common/tikzpreview.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <QDesktopWidget>
2626
#include <QGraphicsProxyWidget>
2727
#include <QMenu>
28+
#include <QScreen>
2829
#include <QScrollBar>
2930
#include <QToolBar>
3031

@@ -92,7 +93,7 @@ void TikzPreview::contextMenuEvent(QContextMenuEvent *event)
9293

9394
QSize TikzPreview::sizeHint() const
9495
{
95-
const int screenWidth = QApplication::desktop()->availableGeometry().width();
96+
const int screenWidth = this->screen()->geometry().width();
9697
if (screenWidth > 1200)
9798
return QSize(500, 400);
9899
else if (screenWidth > 1024)
@@ -404,7 +405,7 @@ void TikzPreview::setBackgroundColor(QColor color)
404405
void TikzPreview::wheelEvent(QWheelEvent *event)
405406
{
406407
if (event->modifiers() == Qt::ControlModifier) {
407-
if (event->delta() > 0)
408+
if (event->angleDelta().y() > 0)
408409
zoomIn();
409410
else
410411
zoomOut();

common/tikzpreviewgenerator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ static QString createTempTikzFile(const QString &tikzFileBaseName, const QString
476476
QTextStream tikzStream(&tikzFile);
477477
codecProfile->configureStreamEncoding(tikzStream);
478478

479-
tikzStream << tikzCode << endl;
479+
tikzStream << tikzCode << Qt::endl;
480480
tikzStream.flush();
481481

482482
tikzFile.close();

0 commit comments

Comments
 (0)