Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need javascript callback exposed #301

Open
violinner opened this issue Feb 5, 2020 · 1 comment
Open

need javascript callback exposed #301

violinner opened this issue Feb 5, 2020 · 1 comment

Comments

@violinner
Copy link

Tests of web-applications that create data grids & histograms sometimes require asynchronous JavaScript calls to the presentation vendor's API, for instance, with Tableau.

waitForJavascriptCallback() is protected and cannot be called from an arbitrary BrowserTest test command.

Please expose waitForJavascriptCallback() as public.

@fhoeben
Copy link
Owner

fhoeben commented Feb 5, 2020

Can you elaborate a bit on what your test will do? I don't assume normal end users will be typing callback function's in the browser's console window. ;-)

To achieve the goal of readable and maintainable tests I always found that creating a Java subclass of BrowserTest that offers a method that wraps some complex JavaScript implementation of a test-step a good trade-off.

If you want to do your JavaScript directly from the wiki, doesn't (the publicly available) execute script method or (executeJavascriptUntilIs) suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants