-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Arguments for firefoxprofile #321
Comments
No backward compatibility issues would arise if FirefoxOptions would be supported in addition to and not instead of profile, correct? I would favour a change that allows |
Yeah its backward compatible if you find a mechanisch to extinguish the two I use "with profile" for chrome as well (example headless), this also works for mobile emulation
|
Yes so that's why I though it would be good to support
(where its probably better to rename the variable to |
TLDR: FirefoxOptions instead FirefoxProfile
Main reason: we want to start firefox headless, for that we need access to arguments
those are accessible in FirefoxOptions not FirefoxProfile
and for more overal compatibility with chrome FirefoxOptions has my preference.
I know this cause issues for existing profile uses, but hope you will consider it anyway
The text was updated successfully, but these errors were encountered: