Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Arguments for firefoxprofile #321

Open
teunisv opened this issue May 22, 2020 · 3 comments
Open

ENH: Arguments for firefoxprofile #321

teunisv opened this issue May 22, 2020 · 3 comments

Comments

@teunisv
Copy link
Contributor

teunisv commented May 22, 2020

TLDR: FirefoxOptions instead FirefoxProfile

Main reason: we want to start firefox headless, for that we need access to arguments
those are accessible in FirefoxOptions not FirefoxProfile
and for more overal compatibility with chrome FirefoxOptions has my preference.

I know this cause issues for existing profile uses, but hope you will consider it anyway

@fhoeben
Copy link
Owner

fhoeben commented May 22, 2020

No backward compatibility issues would arise if FirefoxOptions would be supported in addition to and not instead of profile, correct?

I would favour a change that allows with options (also for chrome) to allow options to be specified...

@teunisv
Copy link
Contributor Author

teunisv commented May 22, 2020

Yeah its backward compatible if you find a mechanisch to extinguish the two

I use "with profile" for chrome as well (example headless), this also works for mobile emulation

|script         |list fixture                                 |
|add            |headless                                     |
|add            |disable-gpu                                  |
|$args=         |copy list                                    |
|start          |map fixture                                  |
|set value      |$args   |for|args                            |
|set value      |false   |for|prefs.safebrowsing.enabled      |
|$chromeProfile=|copy map                                     |

|script          |selenium driver setup             |
|start driver for|chrome|with profile|$chromeProfile|

@fhoeben
Copy link
Owner

fhoeben commented May 22, 2020

Yes so that's why I though it would be good to support

|start driver for|chrome|with options|$chromeProfile|

(where its probably better to rename the variable to chromeOptions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants