Skip to content

Commit 8183089

Browse files
committed
upgrade node to v 24
1 parent ae41ad8 commit 8183089

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Setup Node.js
2929
uses: actions/setup-node@v4
3030
with:
31-
node-version: 20
31+
node-version: 24
3232
- name: Build JS bundle
3333
run: npm install
3434
- name: Build site

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- name: Setup Node.js
1212
uses: actions/setup-node@v4
1313
with:
14-
node-version: 20
14+
node-version: 24
1515
- name: Install dependencies
1616
run: npm install
1717
- name: Lints

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- name: Setup Node.js
1515
uses: actions/setup-node@v4
1616
with:
17-
node-version: 20
17+
node-version: 24
1818
- name: Install dependencies
1919
run: npm install
2020
- uses: jamesmortensen/chromedriver-matcher-action@v1

docs/demos/1-simple/index.html

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -749,20 +749,20 @@ <h2>Simple</h2>
749749
<script type="module">
750750
(async () => {
751751
try {
752-
let DataTable;
753-
754-
// Try ES module import first
755-
try {
756-
const module = await import("../dist/module.js");
757-
DataTable = module.DataTable;
758-
} catch (moduleError) {
759-
console.log("ES module import failed, falling back to UMD:", moduleError);
760-
// Fallback to UMD
761-
if (window.simpleDatatables && window.simpleDatatables.DataTable) {
762-
DataTable = window.simpleDatatables.DataTable;
763-
} else {
764-
throw new Error("DataTable not available in either ES module or UMD");
765-
}
752+
let DataTable
753+
754+
// Try ES module import first
755+
try {
756+
const module = await import("../dist/module.js")
757+
DataTable = module.DataTable
758+
} catch (moduleError) {
759+
console.log("ES module import failed, falling back to UMD:", moduleError)
760+
// Fallback to UMD
761+
if (window.simpleDatatables && window.simpleDatatables.DataTable) {
762+
DataTable = window.simpleDatatables.DataTable
763+
} else {
764+
throw new Error("DataTable not available in either ES module or UMD")
765+
}
766766
}
767767

768768
window.dt = new DataTable("#demo-table", {
@@ -784,12 +784,12 @@ <h2>Simple</h2>
784784
]
785785
})
786786

787-
console.log("DataTable initialized successfully");
788-
} catch (error) {
789-
console.error("Error initializing DataTable:", error);
790-
window.lastError = error.message;
791-
}
792-
})();
787+
console.log("DataTable initialized successfully")
788+
} catch (error) {
789+
console.error("Error initializing DataTable:", error)
790+
window.lastError = error.message
791+
}
792+
})()
793793
</script>
794794
</body>
795795
</html>

0 commit comments

Comments
 (0)