Skip to content

Conversation

@workbysaran
Copy link
Contributor

Resolved / Related Issues
Added a new setting to disable smooth scrolling across all layouts and scrollable components in the application

Closes #15962

Steps used to test these changes

  1. Navigate to Settings > Appearance
  2. Toggle "Enable smooth scrolling" setting
  3. Verify scrolling behavior in all layout modes:
    • Details layout
    • List layout
    • Cards layout
    • Grid layout
    • Columns layout
  4. Verify scrolling behavior in the sidebar navigation
  5. Verify scrolling behavior on the home page
  6. Verify scrolling behavior on the Settings page
  7. Verify setting persists after app restart
  8. Verify smooth scrolling is enabled by default for new users

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jan 8, 2026
@yaira2 yaira2 changed the title Feature: Added a new setting to disable smooth scrolling across all layouts and scrollable components in the application Feature: Added setting to disable smooth scrolling Jan 9, 2026
@yaira2
Copy link
Member

yaira2 commented Jan 12, 2026

@workbysaran instead of manually setting each ScrollViewer, do you think we can follow the approach that we use for other overrides in AppResourcesService.cs?

…e Appearance settings with a resource string for localization.
…bindings, code, and dependency properties from custom controls and views.
@workbysaran
Copy link
Contributor Author

workbysaran commented Jan 13, 2026

@workbysaran instead of manually setting each ScrollViewer, do you think we can follow the approach that we use for other overrides in AppResourcesService.cs?

@yaira2
Good suggestion! I've implemented it using the AppResourcesService pattern.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

}

/// <inheritdoc/>
public bool EnableSmoothScrolling
Copy link
Member

@0x5bfa 0x5bfa Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe IsScrollInertiaEnabled to align with the name in the codebase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SmoothScrolling is more understandable.

…etters from ListView and GridView styles in App.xaml.
@yaira2
Copy link
Member

yaira2 commented Jan 13, 2026

Good suggestion! I've implemented it using the AppResourcesService pattern.

@workbysaran thanks! This looks a lot cleaner.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 13, 2026
@yaira2 yaira2 merged commit 0594bae into files-community:main Jan 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add setting to disable smooth scrolling

3 participants