-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Feature: Added setting to disable smooth scrolling #18030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added setting to disable smooth scrolling #18030
Conversation
…ayouts and scrollable components in the application
|
@workbysaran instead of manually setting each ScrollViewer, do you think we can follow the approach that we use for other overrides in |
…e Appearance settings with a resource string for localization.
…bindings, code, and dependency properties from custom controls and views.
…yles and ThemeResource bindings
@yaira2 |
0x5bfa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public bool EnableSmoothScrolling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe IsScrollInertiaEnabled to align with the name in the codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SmoothScrolling is more understandable.
…etters from ListView and GridView styles in App.xaml.
@workbysaran thanks! This looks a lot cleaner. |
yaira2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Added a new setting to disable smooth scrolling across all layouts and scrollable components in the application
Closes #15962
Steps used to test these changes