-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache to disk #492
Comments
How dependent is Finch cache on the state of Julia functions? Julia 1.11 and upwards have some better support for provenance tracking for things like a code cache. |
That's awesome! Finch does depend on a few overloaded trait functions (the functions declare whether e.g. In these lines https://github.com/JuliaGPU/GPUCompiler.jl/blob/09b4708ba12e0b19e40f85c64e9105cf666c4d62/src/execution.jl#L139-L140, is it safe to use the world as a key? If I started a julia session at world age e.g. 42, then define foo, I get world age 43. If I start a different session and define bar, wouldn't I still get world age 43? I'm curious if there's a simple interface to the provenance tracking (like a call/dependency graph). If not, I would probably design my own "rewriter state object" |
Within a session, it is safe to use world as a key, across sessions it is not. (Worlds get truncated during precompilation) Note that the hash calculcation in https://github.com/JuliaGPU/GPUCompiler.jl/blob/09b4708ba12e0b19e40f85c64e9105cf666c4d62/src/execution.jl#L160 doesn't use world.
Yeah, https://github.com/JuliaGPU/GPUCompiler.jl/blob/09b4708ba12e0b19e40f85c64e9105cf666c4d62/src/execution.jl#L162 |
Some notes:
We need to use PIDFiles with the stale_age set to a nonzero value otherwise we might run into issues with deadlocking when we control c.
The text was updated successfully, but these errors were encountered: