Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma Launcher: automatic device selection #75

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Karma Launcher: automatic device selection #75

merged 5 commits into from
Aug 22, 2024

Conversation

Finesse
Copy link
Member

@Finesse Finesse commented Aug 15, 2024

Resolves #74

  • The Karma BrowserStack launcher chooses the device automatically depending on the given iOS/Android version
  • Improve the logging a bit
  • Fix an excess underscore in the readme
  • Bump the minor version because of a breaking change

@Finesse Finesse self-assigned this Aug 15, 2024
@Finesse Finesse changed the title Automatic device selection for iOS Karma Launcher: uutomatic device selection Aug 15, 2024
@Finesse Finesse marked this pull request as ready for review August 15, 2024 07:43
@Finesse Finesse requested a review from xnerhu August 15, 2024 07:43
@Finesse Finesse changed the title Karma Launcher: uutomatic device selection Karma Launcher: automatic device selection Aug 16, 2024
@Finesse Finesse requested review from spalt08, bayotop and xnerhu and removed request for xnerhu August 19, 2024 10:51
@Finesse Finesse merged commit 413594a into main Aug 22, 2024
1 check passed
@Finesse Finesse deleted the feature/auto-devices branch August 22, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalt08 spalt08 spalt08 approved these changes

@bayotop bayotop Awaiting requested review from bayotop

@xnerhu xnerhu Awaiting requested review from xnerhu

Assignees

@Finesse Finesse

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Finesse @spalt08