Skip to content

Commit c59e6fc

Browse files
*DateTime patch* (#408)
As DateTime is an inline element, it must be wrapped into a `span` tag so that it can be injected at the right position.
1 parent 3e0ba74 commit c59e6fc

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>org.finos.symphony.messageml</groupId>
88
<artifactId>messageml-utils</artifactId>
9-
<version>1.1.0</version>
9+
<version>1.1.1</version>
1010
<name>MessageML Utils</name>
1111
<url>https://github.com/finos/messageml-utils</url>
1212
<description>A set of utilities for parsing, processing and rendering of MessageML messages

src/main/java/org/finos/symphony/messageml/messagemlutils/elements/DateTime.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,10 @@ public void asPresentationML(XmlPrintStream out, MessageMLContext context) {
121121
attributes.put(ATTR_PML_FORMAT, getAttribute(ATTR_FORMAT));
122122
}
123123
attributes.put(ATTR_PML_VALUE, getAttribute(ATTR_VALUE));
124+
125+
out.openElement(DEFAULT_PRESENTATIONML_TAG);
124126
out.printElement(PRESENTATIONML_TAG, value, attributes);
127+
out.closeElement();
125128
}
126129

127130
@Override

src/test/java/org/finos/symphony/messageml/messagemlutils/elements/DateTimeTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ public void timeDate_works() throws InvalidInputException, IOException, Processi
3232
context.parseMessageML(input, null, MessageML.MESSAGEML_VERSION);
3333

3434
String expectedPresentationML = "<div data-format=\"PresentationML\" data-version=\"2.0\"> "
35-
+ "<time data-entity-id=\"datetime1\" datetime=\"2024-12-31T09:29:47Z\" data-format=\"date\">2024-12-31T09:29:47Z</time> "
36-
+ "<time data-entity-id=\"datetime2\" datetime=\"2025-12-31T09:29:47Z\" data-format=\"time\">2025-12-31T09:29:47Z</time> "
37-
+ "<time data-entity-id=\"datetime3\" datetime=\"2026-12-31T09:29:47Z\" data-format=\"time_secs\">2026-12-31T09:29:47Z</time> "
38-
+ "<time data-entity-id=\"datetime4\" datetime=\"2027-12-31T09:29:47Z\">2027-12-31T09:29:47Z</time> "
35+
+ "<span><time data-entity-id=\"datetime1\" datetime=\"2024-12-31T09:29:47Z\" data-format=\"date\">2024-12-31T09:29:47Z</time></span> "
36+
+ "<span><time data-entity-id=\"datetime2\" datetime=\"2025-12-31T09:29:47Z\" data-format=\"time\">2025-12-31T09:29:47Z</time></span> "
37+
+ "<span><time data-entity-id=\"datetime3\" datetime=\"2026-12-31T09:29:47Z\" data-format=\"time_secs\">2026-12-31T09:29:47Z</time></span> "
38+
+ "<span><time data-entity-id=\"datetime4\" datetime=\"2027-12-31T09:29:47Z\">2027-12-31T09:29:47Z</time></span> "
3939
+ "</div>";
4040
String expectedMarkdown = " 2024-12-31T09:29:47Z 2025-12-31T09:29:47Z 2026-12-31T09:29:47Z 2027-12-31T09:29:47Z ";
4141
assertEquals(expectedPresentationML, context.getPresentationML());

0 commit comments

Comments
 (0)