Skip to content

Commit 3637298

Browse files
authored
Make stability.py work with py3 (web-platform-tests#22538)
Running wpt run --verify was failing in py3 for 2 reasons: * Importing modules from the same dir was not working * iteritems() is not defined for collections
1 parent 5721f78 commit 3637298

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

tools/wptrunner/wptrunner/stability.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import os
66
from collections import OrderedDict, defaultdict
77
from datetime import datetime
8+
from six import iteritems
89

910
from mozlog import reader
1011
from mozlog.formatters import JSONFormatter
@@ -140,10 +141,10 @@ def process_results(log, iterations):
140141
handler = LogHandler()
141142
reader.handle_log(reader.read(log), handler)
142143
results = handler.results
143-
for test_name, test in results.iteritems():
144+
for test_name, test in iteritems(results):
144145
if is_inconsistent(test["status"], iterations):
145146
inconsistent.append((test_name, None, test["status"], []))
146-
for subtest_name, subtest in test["subtests"].iteritems():
147+
for subtest_name, subtest in iteritems(test["subtests"]):
147148
if is_inconsistent(subtest["status"], iterations):
148149
inconsistent.append((test_name, subtest_name, subtest["status"], subtest["messages"]))
149150

@@ -208,7 +209,7 @@ def write_results(log, results, iterations, pr_number=None, use_details=False):
208209
"tests" if len(results) > 1
209210
else "test"))
210211

211-
for test_name, test in results.iteritems():
212+
for test_name, test in iteritems(results):
212213
baseurl = "http://w3c-test.org/submissions"
213214
if "https" in os.path.splitext(test_name)[0].split(".")[1:]:
214215
baseurl = "https://w3c-test.org/submissions"
@@ -236,7 +237,7 @@ def write_results(log, results, iterations, pr_number=None, use_details=False):
236237

237238

238239
def run_step(logger, iterations, restart_after_iteration, kwargs_extras, **kwargs):
239-
import wptrunner
240+
from . import wptrunner
240241
kwargs = copy.deepcopy(kwargs)
241242

242243
if restart_after_iteration:
@@ -278,7 +279,7 @@ def get_steps(logger, repeat_loop, repeat_restart, kwargs_extras):
278279
for kwargs_extra in kwargs_extras:
279280
if kwargs_extra:
280281
flags_string = " with flags %s" % " ".join(
281-
"%s=%s" % item for item in kwargs_extra.iteritems())
282+
"%s=%s" % item for item in iteritems(kwargs_extra))
282283
else:
283284
flags_string = ""
284285

tools/wptrunner/wptrunner/wptrunner.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ def run_tests(config, test_paths, product, **kwargs):
339339

340340

341341
def check_stability(**kwargs):
342-
import stability
342+
from . import stability
343343
if kwargs["stability"]:
344344
logger.warning("--stability is deprecated; please use --verify instead!")
345345
kwargs['verify_max_time'] = None

0 commit comments

Comments
 (0)