Skip to content

Commit ab05bb7

Browse files
authored
Fix breakage with app hosting beta API switch (#7896)
* Fix breakage with app hosting beta API switch * Changelog
1 parent 45991d4 commit ab05bb7

File tree

4 files changed

+2
-17
lines changed

4 files changed

+2
-17
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
- Fixes an error creating a rollout with App Hosting in the beta API (#7896)
12
- Added support for Next.js 15. (#7588)

src/apphosting/backend.spec.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,6 @@ describe("apphosting setup functions", () => {
136136
expect(updateTrafficStub).to.be.calledWith(projectId, location, backendId, {
137137
rolloutPolicy: {
138138
codebaseBranch: "main",
139-
stages: [
140-
{
141-
progression: "IMMEDIATE",
142-
targetPercent: 100,
143-
},
144-
],
145139
},
146140
});
147141
});

src/apphosting/backend.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -361,12 +361,6 @@ export async function setDefaultTrafficPolicy(
361361
const traffic: DeepOmit<apphosting.Traffic, apphosting.TrafficOutputOnlyFields | "name"> = {
362362
rolloutPolicy: {
363363
codebaseBranch: codebaseBranch,
364-
stages: [
365-
{
366-
progression: "IMMEDIATE",
367-
targetPercent: 100,
368-
},
369-
],
370364
},
371365
};
372366
const op = await apphosting.updateTraffic(projectId, location, backendId, traffic);

src/gcp/apphosting.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ export interface Rollout {
139139
pauseTime: string;
140140
error?: Error;
141141
build: string;
142-
stages?: RolloutStage[];
143142
displayName?: string;
144143
createTime: string;
145144
updateTime: string;
@@ -193,9 +192,7 @@ export type TrafficOutputOnlyFields =
193192
| "updateTime"
194193
| "etag"
195194
| "uid"
196-
| "rolloutPolicy.disabledTime"
197-
| "rolloutPolicy.stages.startTime"
198-
| "rolloutPolicy.stages.endTime";
195+
| "rolloutPolicy.disabledTime";
199196

200197
assertImplements<TrafficOutputOnlyFields, RecursiveKeyOf<Traffic>>();
201198

@@ -213,7 +210,6 @@ export interface RolloutPolicy {
213210
codebaseBranch?: string;
214211
codebaseTagPattern?: string;
215212
// end oneof trigger
216-
stages?: RolloutStage[];
217213
disabled?: boolean;
218214

219215
// TODO: This will be undefined if disabled is not true, right?

0 commit comments

Comments
 (0)