Skip to content

Commit ce14fa6

Browse files
authoredDec 27, 2024
Fix storage-integeration-test (#8083)
* Adding sleeps and explicitly setup chrome on the GH action runner * browset actions * browser actions * Try pinning to ubuntu 22.04
1 parent 4e7b492 commit ce14fa6

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed
 

‎.github/workflows/node-test.yml

+11-1
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ jobs:
8989
distribution: temurin
9090

9191
- uses: actions/checkout@v4
92+
- name: Setup Chrome
93+
uses: browser-actions/setup-chrome@v1.7.2
94+
with:
95+
install-dependencies: true
96+
install-chromedriver: true
9297
- uses: actions/setup-node@v3
9398
with:
9499
node-version: ${{ matrix.node-version }}
@@ -146,7 +151,7 @@ jobs:
146151
integration:
147152
needs: unit
148153
if: contains(fromJSON('["push", "merge_group"]'), github.event_name)
149-
runs-on: ubuntu-latest
154+
runs-on: ubuntu-22.04
150155

151156
env:
152157
FIREBASE_EMULATORS_PATH: ${{ github.workspace }}/emulator-cache
@@ -184,6 +189,11 @@ jobs:
184189
node-version: ${{ matrix.node-version }}
185190
cache: npm
186191
cache-dependency-path: npm-shrinkwrap.json
192+
- name: Setup Chrome
193+
uses: browser-actions/setup-chrome@v1.7.2
194+
with:
195+
install-dependencies: true
196+
install-chromedriver: true
187197
- name: Cache firebase emulators
188198
uses: actions/cache@v3
189199
with:

‎scripts/storage-emulator-integration/run.sh

+9
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,19 @@ firebase setup:emulators:storage
1212

1313
mocha scripts/storage-emulator-integration/internal/tests.ts
1414

15+
# Brief sleep between tests to make sure emulators shut down fully.
16+
sleep 5
17+
1518
mocha scripts/storage-emulator-integration/rules/*.test.ts
1619

20+
sleep 5
21+
1722
mocha scripts/storage-emulator-integration/import/tests.ts
1823

24+
sleep 5
25+
1926
mocha scripts/storage-emulator-integration/multiple-targets/tests.ts
2027

28+
sleep 5
29+
2130
mocha scripts/storage-emulator-integration/conformance/*.test.ts

0 commit comments

Comments
 (0)