Fix invalid option names in Firestore backup schedule commands (#7481)

* Use `-d` short name for database

* Remove invalid and ambiguous short names

* Update CHANGELOG

* Lint CHANGELOG

Author: TomasMorton

CHANGELOG.md

@@ -9,3 +9,4 @@
 - Released version [email protected], which adds Emulator UI support for firealerts events.
 - Improved errors when an incorrect service ID is passed to `firebase deploy --only dataconnect:serviceId`.
 - Fixed display of errors in Firestore commands when using JSON or noninteractive modes. (#7482)
+- Fixed an issue where Firestore backup schedule commands had invalid short option names. (#7481)

src/commands/firestore-backups-schedules-create.ts

@@ -20,13 +20,13 @@ import { FirebaseError } from "../error";
 export const command = new Command("firestore:backups:schedules:create")
   .description("Create a backup schedule under your Cloud Firestore database.")
   .option(
-    "-db, --database <databaseId>",
+    "-d, --database <databaseId>",
     "Database under which you want to create a schedule. Defaults to the (default) database",
   )
-  .option("-rt, --retention <duration>", "duration string (e.g. 12h or 30d) for backup retention")
-  .option("-rc, --recurrence <recurrence>", "Recurrence settings; either DAILY or WEEKLY")
+  .option("--retention <duration>", "duration string (e.g. 12h or 30d) for backup retention")
+  .option("--recurrence <recurrence>", "Recurrence settings; either DAILY or WEEKLY")
   .option(
-    "-dw, --day-of-week <dayOfWeek>",
+    "--day-of-week <dayOfWeek>",
     "On which day of the week to perform backups; one of MONDAY, TUESDAY, WEDNESDAY, THURSDAY, FRIDAY, SATURDAY, or SUNDAY",
   )
   .before(requirePermissions, ["datastore.backupSchedules.create"])

src/commands/firestore-backups-schedules-list.ts

@@ -10,7 +10,7 @@ import { PrettyPrint } from "../firestore/pretty-print";
 export const command = new Command("firestore:backups:schedules:list")
   .description("List backup schedules under your Cloud Firestore database.")
   .option(
-    "-db, --database <databaseId>",
+    "-d, --database <databaseId>",
     "Database whose schedules you wish to list. Defaults to the (default) database.",
   )
   .before(requirePermissions, ["datastore.backupSchedules.list"])

src/commands/firestore-backups-schedules-update.ts

@@ -13,7 +13,7 @@ import { FirebaseError } from "../error";
 
 export const command = new Command("firestore:backups:schedules:update <backupSchedule>")
   .description("Update a backup schedule under your Cloud Firestore database.")
-  .option("-rt, --retention <duration>", "duration string (e.g. 12h or 30d) for backup retention")
+  .option("--retention <duration>", "duration string (e.g. 12h or 30d) for backup retention")
   .before(requirePermissions, ["datastore.backupSchedules.update"])
   .before(warnEmulatorNotSupported, Emulators.FIRESTORE)
   .action(async (backupScheduleName: string, options: FirestoreOptions) => {